Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not add zdbId if only DE-599 has ZDB info #2112 #2113

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

TobiasNx
Copy link
Contributor

See #2112.

zdbId links should not be added if DE-599 states zdbInfo. following the info of Verbundgruppe. See #2112

@TobiasNx
Copy link
Contributor Author

The build seems to break, but I all test are working and I did not change anything on the workflows. @fsteeg assumes that this error is due to changes with github: actions/runner-images#10636 .

dr0i added a commit that referenced this pull request Dec 17, 2024
Since github unses ubuntu-24.04 as ubuntu-latest the sbt runner is
missing. This "action" installs the official sbt runner.
@dr0i
Copy link
Member

dr0i commented Dec 17, 2024

The master branch also failed. With 3b464f4 it builds alright.

@TobiasNx
Copy link
Contributor Author

The master branch also failed. With 3b464f4 it builds alright.

I reruned the latest master action, it worked before.

@dr0i
Copy link
Member

dr0i commented Dec 17, 2024

What I meant: the master was failing. You can see this here, 4 days ago (the merge I did : https://github.com/hbz/lobid-resources/actions ).
However, if you merge the master now into this PR , it also will be build succesfully by github actions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Review
Development

Successfully merging this pull request may close these issues.

2 participants