567 contained examples of work

[ChristophEwertowski]

Resolves #567

Also #516 and lobid/lodmill#784

[ChristophEwertowski]

Will put the changes later on test. For exampleOfWork of MAB 304-1.a see CT003012479 (commit change). For 303-1 see HT018781534 (commit change).
For containsExampleOfWork (MAB 303t1) see HT018857620 (commit change).

Is it necessary to include the type Work if the properties are called "exampleOfWork" and "containsExampleOfWork"? Because there is no GND-Id for the creators I also added the living statistics at the end of the names. I didn't include MAB 521 because it has nothing to do with work titles.

[acka47]

This already looks quite good. I commented on the examples and suggested two changes.

Is it necessary to include the type Work if the properties are called "exampleOfWork" and "containsExampleOfWork"?

We should have a type for every object if possible. So if it doesn't create any problems I suggest to keep/add it.

Because there is no GND-Id for the creators I also added the living statistics at the end of the names.

Very good. As noted in the comment on https://github.com/hbz/lobid-resources/pull/671/files#diff-9dcab9b0d92cdc0904d7aa5a68497b6d it is still missing for some.

I didn't include MAB 521 because it has nothing to do with work titles.

These might not be "work titles" in the librarian sense that they put work into making them unambiguous. However, it might make sense to use the same approach for modeling this in RDF. I am not sure about this. Let's discuss this at hbz/lobid#287 later.

[acka47]

This looks very similar to the one above but it has a different GND ID. To make the difference between those clear, we will also have to add the sub title from sub field u, here <subfield code="u">Trauermarsch</subfield>. See also #556 (comment).

[acka47]

It would be nice to also add the information from subfields p and d like we do e.g. at https://github.com/hbz/lobid-resources/pull/671/files#diff-5dd561891677f7164f7d7c47a1d0438b.

[ChristophEwertowski]

Added the improvements to test. See HT018857620 (test, json) for subfield u. There are also cases where the subfield appears multiple times.
See HT018781534 (test, json) for additional creatorOfWork and type Work.
Also added MAB 521 where no 303t exists (example HT018138676 (test, json)).
CT003012479 misses exampleOfWork (json) although it's in the branch. Have to ask @dr0i about it tomorrow.

[acka47]

+1 from except for one last small change. I checked the GND and it uses periods as delimiter between title and subtitle(s), see e.g. http://d-nb.info/gnd/300169914. I think we should also do so.

Also, http://test.lobid.org/resources/CT003012479.json looks good for me (except for the encoding which generally is problematic on test):

{
  "id" : "http://lobid.org/resources/CT003012479#!",
  "exampleOfWork" : {
    "label" : "<<La>> Belisa Ossia La Fedeltá Riconosciuta",
    "type" : [ "Work" ]
  }
}

[ChristophEwertowski]

For the new changes look at HT018857620 (json, test). For example:

• "label" : "Sinfonien, D 759 (h-Moll)" (GND)
• "label" : "La damnation de Faust. Invocation à la nature, Singstimme, Orchester", (GND)

[acka47]

Everything looks good now. Thanks for aligning the presentation with the GND! +1

[dr0i]

+1

[dr0i]

Deployed to staging, see e.g. http://stage.lobid.org/resources/HT018857620.json.

[dr0i]

Deployed to production, see e.g. http://lobid.org/resources/HT018857620.json.
Closed.