-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Also pull Prussian districts from Wikidata for matching #854
Conversation
Looks good. |
New index is built. It has around 40 more entries than the old index. |
@@ -70,7 +70,7 @@ | |||
|
|||
{ | |||
put("99", "Q22865 Q262166 Q253019 Q1852178 Q15632166"); | |||
put("97", "Q106658"); | |||
put("97", "Q106658 Q5283531"); | |||
put("96", "Q829277"); | |||
put("36", "Q3146899 Q2072238"); | |||
put("97", "Q106658"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, there are two entries of 97
, which is not good. As long as the entries are same this doesn't have an effect. Now, as they are different, it does behave differently - it overwrites the first entry with the second entry, ignoring "Q5283531".
I was wondering why e.g. https://www.wikidata.org/wiki/Q1787322 wasn't enriched. There is a bug in defining |
Deplyoed to production, see e.g. http://lobid.org/resources/search?q=spatial.id%3A"http%3A%2F%2Fwww.wikidata.org%2Fentity%2FQ1787322". Closed. |
See #627 (comment)
@dr0i I also adjusted the code so that entries with notations 97 are also matched with the prussian districts. I hope I did it correctly.