Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get rid of ssl keys for vocabs.lobid.org #385

Closed
dr0i opened this issue Nov 23, 2018 · 2 comments
Closed

Get rid of ssl keys for vocabs.lobid.org #385

dr0i opened this issue Nov 23, 2018 · 2 comments
Assignees
@dr0i

Comments

@dr0i
Copy link
Member

dr0i commented Nov 23, 2018 •
edited
Loading

Working on #383 I discovered that we don't use http://vocabs.lobid.org/, right? If so, we don't need to get the SSL keys for that subdomain.
@dr0i dr0i added the ready label Nov 23, 2018
@acka47 acka47 assigned dr0i and unassigned acka47 Mar 5, 2019
@acka47
Copy link
Contributor

acka47 commented Mar 5, 2019

+1 Do we have to do anything or can we close the issue?

@dr0i
Copy link
Member Author

dr0i commented Mar 18, 2019

Hm, no, we just don't have to forget to not apply for a new ssl key for this subdomain.
Closing.

@dr0i dr0i closed this as completed Mar 18, 2019
@dr0i dr0i removed the ready label Mar 18, 2019
Phu2 added a commit that referenced this issue Sep 3, 2024
@Phu2
Corrects content type of SVGs from Wikimedia. Resolves #385
11e8dd2 
in fact PNGs are delivered when width parameter is used
Phu2 added a commit that referenced this issue Sep 24, 2024
@Phu2
Corrects content type of SVGs from Wikimedia. Resolves #385
e1083c9 
in fact PNGs are delivered when width parameter is used
Phu2 added a commit that referenced this issue Dec 10, 2024
@Phu2
Fix imagesproxy for image paths without query parameter
d562579 
Resolves #385
eg. https://lobid.org/imagesproxy?url=https://en.wikipedia.org/static/favicon/wikipedia.ico
@Phu2 Phu2 mentioned this issue Dec 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dr0i dr0i

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@acka47 @dr0i