Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve accessibility #508

Merged
merged 6 commits into from
Jul 9, 2024
Merged

Improve accessibility #508

merged 6 commits into from
Jul 9, 2024

Conversation

Phu2
Copy link
Contributor

@Phu2 Phu2 commented Sep 18, 2023

This PR seeks to meet the requirements for

  • Prüfschritt 0.0.1 Erklärung zur Barrierefreiheit vorhanden
  • Prüfschritt 9.1.4.3 Kontraste von Texten ausreichend

@Phu2 Phu2 linked an issue Sep 18, 2023 that may be closed by this pull request
4 tasks
@Phu2 Phu2 self-assigned this Sep 18, 2023
lobid.css at least in order to override other stylesheets
@Phu2 Phu2 mentioned this pull request Jan 17, 2024
4 tasks
@Phu2 Phu2 force-pushed the 507-fix-accessibility-issues-reported branch 3 times, most recently from 6df0b16 to c7904d7 Compare July 9, 2024 09:29
@Phu2 Phu2 force-pushed the 507-fix-accessibility-issues-reported branch from c7904d7 to f634813 Compare July 9, 2024 10:05
@Phu2 Phu2 changed the title WIP: Improve accessibility Improve accessibility Jul 9, 2024
@Phu2 Phu2 requested a review from fsteeg July 9, 2024 10:20
@Phu2
Copy link
Contributor Author

Phu2 commented Jul 9, 2024

Deployed to http://stage.lobid.org/
@acka47 has already completed the functional review
@fsteeg Code review

<i className="fa fa-pencil" aria-hidden="true"></i> Blog
</a>
</span>
</div>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to include formatting changes, makes it hard to see what actually changed.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, sorry. Only cleaned up indentation in order to check for correct closing tags more easily.

@Phu2 Phu2 merged commit 979eeb5 into master Jul 9, 2024
1 check passed
@Phu2 Phu2 deleted the 507-fix-accessibility-issues-reported branch July 9, 2024 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix accessibility issues reported
2 participants