UBER-851: fix titles in ListView (#3678)

Signed-off-by: Alexander Platov <sas_lord@mail.ru>
hcengineering · Sep 11, 2023 · 466dcdf · 466dcdf
1 parent 1246b5a
commit 466dcdf
Show file tree

Hide file tree

Showing 5 changed files with 12 additions and 18 deletions.
diff --git a/packages/presentation/src/components/NavLink.svelte b/packages/presentation/src/components/NavLink.svelte
@@ -82,8 +82,6 @@
 <style lang="scss">
   span,
   a {
-    display: flex;
-    align-items: center;
     min-width: 0;
     font-weight: inherit;
 

diff --git a/packages/theme/styles/components.scss b/packages/theme/styles/components.scss
@@ -1052,7 +1052,6 @@
     border-radius: 1.625rem;
     transition: flex-shrink 0.25s cubic-bezier(0.38, 0.01, 0.33, 1) 0s;
 
-    &:not(:empty) { min-width: 7.5rem; }
     &:hover {
       flex-shrink: .5;
       min-width: initial;

diff --git a/plugins/tracker-resources/src/components/issues/ParentNamesPresenter.svelte b/plugins/tracker-resources/src/components/issues/ParentNamesPresenter.svelte
@@ -33,7 +33,7 @@
       {#each value.parents as parentInfo}
         <!-- svelte-ignore a11y-click-events-have-key-events -->
         <span
-          class="name overflow-label cursor-pointer"
+          class="parent-label overflow-label cursor-pointer"
           title={parentInfo.parentTitle}
           on:click={() => handleIssueEditorOpened(parentInfo)}
         >
@@ -46,7 +46,7 @@
 
 <style lang="scss">
   .root {
-    display: flex;
+    display: inline-flex;
     margin-left: 0;
     min-width: 0;
 
@@ -56,7 +56,9 @@
       color: var(--theme-dark-color);
     }
 
-    .name {
+    .parent-label {
+      flex-shrink: 5;
+
       &:hover {
         color: var(--theme-caption-color);
         text-decoration: underline;

diff --git a/plugins/tracker-resources/src/components/issues/TitlePresenter.svelte b/plugins/tracker-resources/src/components/issues/TitlePresenter.svelte
@@ -30,21 +30,13 @@
 
 {#if value}
   <span
-    class="name overflow-label select-text"
+    class="presenter-label select-text"
     class:with-margin={shouldUseMargin}
     class:list={kind === 'list'}
     style:max-width={maxWidth}
     title={value.title}
   >
-    <DocNavLink
-      object={value}
-      {disabled}
-      {onClick}
-      component={tracker.component.EditIssue}
-      inline
-      shrink={1}
-      colorInherit
-    >
+    <DocNavLink object={value} {onClick} component={tracker.component.EditIssue} shrink={1} colorInherit>
       {value.title}
     </DocNavLink>
   </span>
@@ -55,7 +47,10 @@
 {/if}
 
 <style lang="scss">
-  .name {
+  .presenter-label {
+    overflow: hidden;
+    display: inline-flex;
+    align-items: center;
     flex-shrink: 1;
     min-width: 1rem;
 

diff --git a/tests/sanity/tests/tracker.utils.ts b/tests/sanity/tests/tracker.utils.ts
@@ -199,7 +199,7 @@ export async function checkIssueFromList (page: Page, issueName: string): Promis
 }
 
 export async function openIssue (page: Page, name: string): Promise<void> {
-  await page.click(`.antiList__row:has-text("${name}") .name a`, {
+  await page.click(`.antiList__row:has-text("${name}") .presenter-label a`, {
     timeout: 15000
   })
 }