UBER-289: Prevent empty changes to go into transactions. (#3277)

Signed-off-by: Andrey Sobolev <haiodo@gmail.com>
hcengineering · May 29, 2023 · 6b7e83c · 6b7e83c
1 parent eae0107
commit 6b7e83c
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/plugins/recruit-resources/src/components/EditVacancy.svelte b/plugins/recruit-resources/src/components/EditVacancy.svelte
@@ -106,7 +106,7 @@
     const updates: Partial<Data<Vacancy>> = {}
     const trimmedName = rawName.trim()
 
-    if (trimmedName.length > 0 && trimmedName !== object.name) {
+    if (trimmedName.length > 0 && trimmedName !== object.name?.trim()) {
       updates.name = trimmedName
     }
 

diff --git a/plugins/tracker-resources/src/components/issues/edit/EditIssue.svelte b/plugins/tracker-resources/src/components/issues/edit/EditIssue.svelte
@@ -108,7 +108,7 @@
 
     const trimmedTitle = title.trim()
 
-    if (trimmedTitle.length > 0 && trimmedTitle !== issue.title) {
+    if (trimmedTitle.length > 0 && trimmedTitle !== issue.title?.trim()) {
       await client.update(issue, { title: trimmedTitle })
     }
   }

diff --git a/plugins/tracker-resources/src/components/templates/EditIssueTemplate.svelte b/plugins/tracker-resources/src/components/templates/EditIssueTemplate.svelte
@@ -97,7 +97,7 @@
 
     const trimmedTitle = title.trim()
 
-    if (trimmedTitle.length > 0 && trimmedTitle !== template.title) {
+    if (trimmedTitle.length > 0 && trimmedTitle !== template.title?.trim()) {
       await client.update(template, { title: trimmedTitle })
     }
   }