fix: popup glitches caused by long calculations #4511
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution checklist
Brief description
When we open a popup,
fitPopupPositionedElement
is called several times for multiple reasons, which calculates the position of the popup on the screen:changeContent
event from theCreateIssue
component.resizeObserver
fromPopupInstance
.The problem is that we get the popup sizes too late, just from
resizeObserver
. This causes incorrect calculations of theleft: calc(50% - -0.5px)
parameter.I suggest setting the initial sizes as soon as the DOM element is ready.
Screencast
bold-fixed-issue-popup-glitches.mov
Checklist
Related issues
Resolves #4510
Contributor requirements