Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: popup glitches caused by long calculations #4511

Merged
merged 1 commit into from
Feb 5, 2024
Merged

fix: popup glitches caused by long calculations #4511

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions packages/ui/src/components/PopupInstance.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,8 +112,8 @@
let oldModalHTML: HTMLElement | undefined = undefined

$: if (modalHTML !== undefined && oldModalHTML !== modalHTML) {
clientWidth = -1
clientHeight = -1
clientWidth = modalHTML.clientWidth
clientHeight = modalHTML.clientHeight
oldModalHTML = modalHTML
fitPopup(modalHTML, element, contentPanel)
showing = true
Expand All @@ -127,7 +127,9 @@
}

export function fitPopupInstance (): void {
if (modalHTML) fitPopup(modalHTML, element, contentPanel)
if (modalHTML) {
fitPopup(modalHTML, element, contentPanel)
}
}

$: if ($deviceInfo.docWidth <= 900 && !docSize) docSize = true
Expand Down
Loading