Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Board: Fix infinite loop in Activity component for space update #1417

Merged
merged 2 commits into from
Apr 16, 2022
Merged

Board: Fix infinite loop in Activity component for space update #1417

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
646c2e5
Fix infinite loop in Activity component for space update
annano Apr 15, 2022
9d97043
Update proper SpacePresenter mixin
annano Apr 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion models/view/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -217,7 +217,7 @@ export function createModel (builder: Builder): void {
)

builder.mixin(core.class.Space, core.class.Class, view.mixin.AttributePresenter, {
presenter: view.component.ObjectPresenter
haiodo marked this conversation as resolved.
Show resolved Hide resolved
presenter: view.component.SpacePresenter
})
}

Expand Down
2 changes: 2 additions & 0 deletions plugins/view-resources/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ import BooleanEditor from './components/BooleanEditor.svelte'
import BooleanPresenter from './components/BooleanPresenter.svelte'
import DateEditor from './components/DateEditor.svelte'
import DatePresenter from './components/DatePresenter.svelte'
import SpacePresenter from './components/SpacePresenter.svelte'
import StringEditor from './components/StringEditor.svelte'
import StringPresenter from './components/StringPresenter.svelte'
import IntlStringPresenter from './components/IntlStringPresenter.svelte'
Expand Down Expand Up @@ -69,6 +70,7 @@ export default async (): Promise<Resources> => ({
Move: Move
},
component: {
SpacePresenter,
StringEditor,
StringPresenter,
NumberEditor,
Expand Down
3 changes: 2 additions & 1 deletion plugins/view/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,7 +201,8 @@ const view = plugin(viewId, {
},
component: {
ObjectPresenter: '' as AnyComponent,
EditDoc: '' as AnyComponent
EditDoc: '' as AnyComponent,
SpacePresenter: '' as AnyComponent
},
icon: {
Table: '' as Asset,
Expand Down