-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow to disable particular items in ObjectPopup #2824
Conversation
Signed-off-by: Denis Bunakalya <denis.bunakalya@xored.com>
@denis-bunakalya I do not like this idea at all. |
Any reason? We need it to show all the selected items, but disable editing for some of them. If we would show only editable items, user sometimes won't see other previously selected items, which are not editable for him |
So you need to disallow deselection of some of items? And potentially it should be shown differently in control. |
Signed-off-by: Denis Bunakalya <denis.bunakalya@xored.com>
Done |
@@ -58,6 +58,7 @@ | |||
|
|||
export let create: ObjectCreate | undefined = undefined | |||
export let readonly = false | |||
export let forbiddenDeselectItemIds: Set<Ref<Doc>> = new Set() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
export let forbiddenDeselectItemIds: Set<Ref<Doc>> = new Set() | |
export let disallowDeselect: Ref<Doc>[]| undefined |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
Signed-off-by: Denis Bunakalya <denis.bunakalya@xored.com>
Contribution checklist
Brief description
Checklist
Related issues
A list of closed updated issues