Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TSK-989: transparent requests (PTO, extra, etc.) when not in department or descendants #2861

Merged
merged 1 commit into from
Mar 30, 2023
Merged

TSK-989: transparent requests (PTO, extra, etc.) when not in department or descendants #2861

merged 1 commit into from
Mar 30, 2023

Conversation

ThetaDR
Copy link
Contributor

@ThetaDR ThetaDR commented Mar 30, 2023

Contribution checklist

Brief description

image
PTO is another department, Vacation was set in currently open department
https://front.hc.engineering/workbench/platform/tracker/TSK-989

Checklist

  • - UI test added to added/changed functionality?
  • - Screenshot is added to PR if applicable ?
  • - Does the code work? Check whether function and logic are correct.
  • - Does Changelog.md is updated with changes?
  • - Does the translations are up to date?
  • - Does it well tested?
  • - Tested for Chrome.
  • - Tested for Safari.
  • - Go through the changed code looking for typos, TODOs, commented LOCs, debugging pieces of code, etc.
  • - Rebase your branch onto master and upstream branch
  • - Is there any redundant or duplicate code?
  • - Are required links are linked to PR?
  • - Does new code is well documented ?

Related issues

A list of closed updated issues

@ThetaDR
TSK-989: transparent requests (PTO, extra, etc.) when not in departme…
2e264f9 
…nt or it's descendants

Signed-off-by: Vyacheslav Tumanov <me@slavatumanov.me>
@ThetaDR ThetaDR requested review from haiodo and BykhovDenis March 30, 2023 14:14
@haiodo haiodo merged commit 18a756a into main Mar 30, 2023
@haiodo haiodo deleted the TSK-989 branch March 30, 2023 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haiodo haiodo haiodo approved these changes

@BykhovDenis BykhovDenis Awaiting requested review from BykhovDenis

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ThetaDR @haiodo