Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tsk-1040: Support draft for DraggableList #2898

Merged
merged 2 commits into from
Apr 6, 2023
Merged

Tsk-1040: Support draft for DraggableList #2898

merged 2 commits into from
Apr 6, 2023

Conversation

mrsadman99
Copy link
Contributor

Contribution checklist

Brief description

Checklist

  • - UI test added to added/changed functionality?
  • - Screenshot is added to PR if applicable ?
  • - Does the code work? Check whether function and logic are correct.
  • - Does Changelog.md is updated with changes?
  • - Does the translations are up to date?
  • - Does it well tested?
  • - Tested for Chrome.
  • - Tested for Safari.
  • - Go through the changed code looking for typos, TODOs, commented LOCs, debugging pieces of code, etc.
  • - Rebase your branch onto master and upstream branch
  • - Is there any redundant or duplicate code?
  • - Are required links are linked to PR?
  • - Does new code is well documented ?

Related issues

A list of closed updated issues

@mrsadman99 mrsadman99 requested review from haiodo and BykhovDenis April 5, 2023 11:10
@mrsadman99 mrsadman99 marked this pull request as ready for review April 5, 2023 11:11
@haiodo
Copy link
Member

haiodo commented Apr 6, 2023

@mrsadman99 Please sign commits.

@mrsadman99 mrsadman99 force-pushed the TSK-1040 branch 2 times, most recently from 5c5f172 to ef40466 Compare April 6, 2023 06:05
Anton Brechka added 2 commits April 6, 2023 13:22
Support draft for DraggableList
d29781c 
Signed-off-by: Anton Brechka <anton.brechka@xored.com>
Add update rank for draft
1741925 
Signed-off-by: Anton Brechka <anton.brechka@xored.com>
@mrsadman99
Copy link
Contributor Author

@mrsadman99 Please sign commits.

Done.

@haiodo haiodo merged commit b2a0266 into main Apr 6, 2023
@haiodo haiodo deleted the TSK-1040 branch April 6, 2023 10:55
mrsadman99 pushed a commit that referenced this pull request Apr 10, 2023
Merge branch 'main' into TSK-1040
3f3d114 
* main: (28 commits)
  Bump and publish bitrix package (#2926)
  TSK-1088: Show Kanban counters (#2924)
  Fix activity is new (#2923)
  TSK-1007: Add comments in talent editor (#2922)
  TSK-1062: Fix merge properly (#2919)
  Replace "you and" (#2921)
  Fix bitrix gmail sync (#2918)
  TSK-997 В Activity Feed таланта писать событие об отправленном письме (#2917)
  TSK-1065: Check model version (#2916)
  TSK-1069. Displaying a Mention, as well as a Comment. Fixed MessageViewer. (#2915)
  TSK-1051 TSK-1052 TSK-1061 Inbox actions (#2914)
  Add commentator to collaborators (#2911)
  Tsk-1040: Support draft for DraggableList (#2898)
  TSK-1015: Bitrix Create Vacancy/Application (#2913)
  Add ignore keys for ClassFilters (#2912)
  Remove contact resolver id check (#2910)
  Add inbox employee bold (#2909)
  Fix notification mark (#2908)
  Inbox attriubute bar (#2907)
  Inbox title overflow fix (#2906)
  ...

Signed-off-by: Anton Brechka <anton.brechka@ezthera.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haiodo haiodo haiodo approved these changes

@BykhovDenis BykhovDenis Awaiting requested review from BykhovDenis

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mrsadman99 @haiodo