TSK-1324: update kanban layout #3118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alexander Platov <sas_lord@mail.ru>
haiodo
reviewed
May 2, 2023
| &:hover { | ||
| color: var(--theme-caption-color); | ||
| background-color: var(--theme-button-hovered); | ||
| background-color: var(--theme-kanban-button-hover); |
haiodo
reviewed
May 2, 2023
| @@ -11,7 +11,7 @@ | |||
| export let object: WithLookup<Doc> | |||
| export let full: boolean | |||
| export let ckeckFilled: boolean = false | |||
| export let kind: 'short' | 'full' | 'list' = 'short' | |||
| export let kind: 'short' | 'full' | 'list' | 'kanban' = 'short' | |||
haiodo
reviewed
May 2, 2023
| background-color: var(--button-bg-hover); | ||
| border-color: var(--button-border-hover); | ||
| color: var(--theme-caption-color); | ||
| background-color: var(--theme-kanban-button-hover); |
haiodo
reviewed
May 2, 2023
| if (accentColors[i] === undefined) { | ||
| accentColors[i] = { | ||
| textColor: 'var(--theme-caption-color)', | ||
| backgroundColor: '175, 175, 175' |
There was a problem hiding this comment.
Themes support for backgroundColor?
haiodo
reviewed
May 2, 2023
| <span class="text-base fs-bold overflow-label content-accent-color pointer-events-none"> | ||
| {#key lth} | ||
| <div | ||
| style:--kanban-header-rgb-color={accentColors[index].backgroundColor ?? '175, 175, 175'} |
There was a problem hiding this comment.
Why it could be undefined? Please use method to return value, do not use defaults in multiple places.
haiodo
reviewed
May 2, 2023
| const defaultFill = 'currentColor' | ||
| $: fill = value ? getPlatformColor(value.color ?? getColorNumberByText(value.name)) : defaultFill | ||
| const dispatchAccentColor = (fill: string) => | ||
| dispatch('accent-color', fill !== defaultFill ? hexToRgb(fill) : { r: 127, g: 127, b: 127 }) |
There was a problem hiding this comment.
We should have some default color constant in CSS and not in code.
There was a problem hiding this comment.
The { r, g, b } object is expected to be translated to HLS
haiodo
reviewed
May 2, 2023
| @@ -18,7 +18,7 @@ | |||
| const dispatch = createEventDispatcher() | |||
|
|
|||
| const dispatchAccentColor = (fill: string) => | |||
| dispatch('accent-color', fill !== defaultFill ? hexToRgb(fill) : 'var(--theme-halfcontent-color)') | |||
| dispatch('accent-color', fill !== defaultFill ? hexToRgb(fill) : { r: 127, g: 127, b: 127 }) | |||
There was a problem hiding this comment.
Default color constant in CSS again.
haiodo
reviewed
May 2, 2023
| if (accentColors[i] === undefined) { | ||
| accentColors[i] = { | ||
| textColor: 'var(--theme-caption-color)', | ||
| backgroundColor: '175, 175, 175' |
haiodo
reviewed
May 2, 2023
|
|
||
| const setAccentColor = (n: number, ev: CustomEvent) => { | ||
| const accColor = rgbToHsl(ev.detail.r, ev.detail.g, ev.detail.b) | ||
| const textColor = !lth ? { r: 255, g: 255, b: 255 } : hslToRgb(accColor.h, accColor.s, 0.3) |
haiodo
reviewed
May 2, 2023
| const setAccentColor = (n: number, ev: CustomEvent) => { | ||
| const accColor = rgbToHsl(ev.detail.r, ev.detail.g, ev.detail.b) | ||
| const textColor = !lth ? { r: 255, g: 255, b: 255 } : hslToRgb(accColor.h, accColor.s, 0.3) | ||
| const bgColor = !lth ? hslToRgb(accColor.h, accColor.s, 0.55) : hslToRgb(accColor.h, accColor.s, 0.9) |
There was a problem hiding this comment.
Let's move 0.55 and 0.9 into CSS if possible.
haiodo
reviewed
May 2, 2023
| <div class="flex-row-center flex-between"> | ||
| {#key lth} | ||
| <div | ||
| style:--kanban-header-rgb-color={accentColors[index].backgroundColor ?? '175, 175, 175'} |
haiodo
approved these changes
May 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution checklist
Brief description
Checklist
Related issues
A list of closed updated issues