Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TSK-1414: Fix exceptions in Kanban #3119

Merged
merged 1 commit into from
May 2, 2023
Merged

TSK-1414: Fix exceptions in Kanban #3119

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion models/all/src/version.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
{ "major": 0, "minor": 6, "patch": 78 }
{"major":0,"minor":6,"patch":92}
2 changes: 1 addition & 1 deletion packages/ui/src/components/icons/HalfUpDown.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,6 @@
const fill: string = 'currentColor'
</script>

<svg width="1rem" height=".5rem" {fill} xmlns="http://www.w3.org/2000/svg" viewBox="0 0 16 8">
<svg width="16" height="8" {fill} xmlns="http://www.w3.org/2000/svg" viewBox="0 0 16 8">
<polygon points="8,3.4 4.7,6.7 11.3,6.7 " />
</svg>
4 changes: 2 additions & 2 deletions plugins/task-resources/src/components/kanban/KanbanView.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -287,13 +287,13 @@
<!-- {@const status = $statusStore.get(state._id)} -->
{#key lth}
<div
style:--kanban-header-rgb-color={accentColors[index].backgroundColor ?? '175, 175, 175'}
style:--kanban-header-rgb-color={accentColors[index]?.backgroundColor ?? '175, 175, 175'}
class="header flex-row-center"
class:gradient={!lth}
>
<span
class="clear-mins fs-bold overflow-label pointer-events-none"
style:color={accentColors[index].textColor ?? 'var(--theme-caption-color)'}
style:color={accentColors[index]?.textColor ?? 'var(--theme-caption-color)'}
>
{#if groupByKey === noCategory}
<Label label={view.string.NoGrouping} />
Expand Down
4 changes: 2 additions & 2 deletions plugins/tracker-resources/src/components/issues/KanbanView.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -305,14 +305,14 @@
<!-- {@const status = $statusStore.get(state._id)} -->
{#key lth}
<div
style:--kanban-header-rgb-color={accentColors[index].backgroundColor ?? '175, 175, 175'}
style:--kanban-header-rgb-color={accentColors[index]?.backgroundColor ?? '175, 175, 175'}
class="header flex-between"
class:gradient={!lth}
>
<div class="flex-row-center gap-1">
<span
class="clear-mins fs-bold overflow-label pointer-events-none"
style:color={accentColors[index].textColor ?? 'var(--theme-caption-color)'}
style:color={accentColors[index]?.textColor ?? 'var(--theme-caption-color)'}
>
{#if groupByKey === noCategory}
<Label label={view.string.NoGrouping} />
Expand Down
8 changes: 6 additions & 2 deletions plugins/view-resources/src/components/list/ListCategories.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,8 +114,12 @@
$: buildModel({ client, _class, keys: config, lookup }).then((res) => {
itemModels = res
res.forEach((m) => {
const key = `list_item_${m.props?.listProps.key}`
if (m.props?.listProps?.fixed) $fixedWidthStore[key] = 0
if (m.props?.listProps?.key !== undefined) {
const key = `list_item_${m.props.listProps.key}`
if (m.props.listProps.fixed) {
$fixedWidthStore[key] = 0
}
}
})
})

Expand Down