Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TSK-1411 Доработка фильтров с датами #3151

Merged
merged 2 commits into from
May 8, 2023
Merged

TSK-1411 Доработка фильтров с датами #3151

merged 2 commits into from
May 8, 2023

Conversation

BykhovDenis
Copy link
Member

Contribution checklist

Brief description

Checklist

  • - UI test added to added/changed functionality?
  • - Screenshot is added to PR if applicable ?
  • - Does the code work? Check whether function and logic are correct.
  • - Does Changelog.md is updated with changes?
  • - Does the translations are up to date?
  • - Does it well tested?
  • - Tested for Chrome.
  • - Tested for Safari.
  • - Go through the changed code looking for typos, TODOs, commented LOCs, debugging pieces of code, etc.
  • - Rebase your branch onto master and upstream branch
  • - Is there any redundant or duplicate code?
  • - Are required links are linked to PR?
  • - Does new code is well documented ?

Related issues

https://front.hc.engineering/workbench/platform/tracker/TSK-1411
A list of closed updated issues

@BykhovDenis
TSK-1411 Date filter improve
0f16615 
Signed-off-by: Denis Bykhov <bykhov.denis@gmail.com>
@BykhovDenis BykhovDenis requested a review from haiodo May 5, 2023 14:53
@BykhovDenis BykhovDenis self-assigned this May 5, 2023
@BykhovDenis
Fix
6b95ca2 
Signed-off-by: Denis Bykhov <bykhov.denis@gmail.com>
@haiodo haiodo merged commit 16da75f into main May 8, 2023
@haiodo haiodo deleted the date_range_filter branch May 8, 2023 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haiodo haiodo haiodo approved these changes

Assignees

@BykhovDenis BykhovDenis

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BykhovDenis @haiodo