Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TSK-742: Use partial binary protocol with ability on/off #3153

Merged
merged 4 commits into from
May 10, 2023
Merged

Conversation

haiodo
Copy link
Member

@haiodo haiodo commented May 9, 2023

Contribution checklist

Brief description

Data transfer from server to client is about 1.8 times less, and docker container server suppose 3000+ smoothly without issues. Memory consumption is about 200-300mb.

Checklist

  • - UI test added to added/changed functionality?
  • - Screenshot is added to PR if applicable ?
  • - Does the code work? Check whether function and logic are correct.
  • - Does Changelog.md is updated with changes?
  • - Does the translations are up to date?
  • - Does it well tested?
  • - Tested for Chrome.
  • - Tested for Safari.
  • - Go through the changed code looking for typos, TODOs, commented LOCs, debugging pieces of code, etc.
  • - Rebase your branch onto master and upstream branch
  • - Is there any redundant or duplicate code?
  • - Are required links are linked to PR?
  • - Does new code is well documented ?

Related issues

A list of closed updated issues

@haiodo haiodo requested a review from BykhovDenis May 9, 2023 18:50
@haiodo haiodo force-pushed the TSK-742v2 branch 5 times, most recently from c36f568 to 16002a3 Compare May 10, 2023 13:01
haiodo added 4 commits May 10, 2023 23:18
Signed-off-by: Andrey Sobolev <haiodo@gmail.com>
Signed-off-by: Andrey Sobolev <haiodo@gmail.com>
Signed-off-by: Andrey Sobolev <haiodo@gmail.com>
Signed-off-by: Andrey Sobolev <haiodo@gmail.com>
@haiodo haiodo merged commit 84b7df4 into main May 10, 2023
@haiodo haiodo deleted the TSK-742v2 branch May 10, 2023 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants