Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UBER-178] New way of All/Active/Backlog should be in URI #3228

Merged
merged 8 commits into from
May 24, 2023

Conversation

wazsone
Copy link
Contributor

@wazsone wazsone commented May 21, 2023

Contribution checklist

Brief description

We need to respect selection of item of Active etc in URI, so filters will be properly handled.

Related issues

https://front.hc.engineering/workbench/platform/tracker/UBER-178

Checklist

  • - UI test added to added/changed functionality?
  • - Screenshot is added to PR if applicable ?
  • - Does the code work? Check whether function and logic are correct.
  • - Does Changelog.md is updated with changes?
  • - Does the translations are up to date?
  • - Does it well tested?
  • - Tested for Chrome.
  • - Tested for Safari.
  • - Go through the changed code looking for typos, TODOs, commented LOCs, debugging pieces of code, etc.
  • - Rebase your branch onto master and upstream branch
  • - Is there any redundant or duplicate code?
  • - Are required links are linked to PR?
  • - Does new code is well documented ?

@wazsone wazsone requested review from haiodo and BykhovDenis May 21, 2023 21:27
@wazsone wazsone self-assigned this May 21, 2023
@wazsone wazsone requested a review from haiodo May 22, 2023 07:19
@wazsone wazsone marked this pull request as draft May 22, 2023 08:32
@wazsone wazsone force-pushed the UBER-178/update-url branch from 0e7c7d9 to 87ea071 Compare May 22, 2023 20:45
@wazsone wazsone marked this pull request as ready for review May 22, 2023 20:53
@wazsone wazsone force-pushed the UBER-178/update-url branch from 67bb047 to 5a05db8 Compare May 23, 2023 10:59
wazsone added 7 commits May 23, 2023 17:10
Signed-off-by: Ruslan Bayandinov <wazsone@ya.ru>
Signed-off-by: Ruslan Bayandinov <wazsone@ya.ru>
Signed-off-by: Ruslan Bayandinov <wazsone@ya.ru>
Signed-off-by: Ruslan Bayandinov <wazsone@ya.ru>
Signed-off-by: Ruslan Bayandinov <wazsone@ya.ru>
Signed-off-by: Ruslan Bayandinov <wazsone@ya.ru>
Signed-off-by: Ruslan Bayandinov <wazsone@ya.ru>
@wazsone wazsone force-pushed the UBER-178/update-url branch from e203cc0 to 1e9f9ad Compare May 23, 2023 13:11
Signed-off-by: Ruslan Bayandinov <wazsone@ya.ru>
@wazsone wazsone requested a review from haiodo May 23, 2023 15:41
@BykhovDenis BykhovDenis merged commit 30a0413 into main May 24, 2023
@BykhovDenis BykhovDenis deleted the UBER-178/update-url branch May 24, 2023 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants