Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UBER-278: add Yes-No to popup, refactor #3289

Merged
merged 3 commits into from
May 30, 2023
Merged

UBER-278: add Yes-No to popup, refactor #3289

merged 3 commits into from
May 30, 2023

Conversation

ThetaDR
Copy link
Contributor

@ThetaDR ThetaDR commented May 30, 2023

Contribution checklist

Brief description

image
image

Checklist

  • - UI test added to added/changed functionality?
  • - Screenshot is added to PR if applicable ?
  • - Does the code work? Check whether function and logic are correct.
  • - Does Changelog.md is updated with changes?
  • - Does the translations are up to date?
  • - Does it well tested?
  • - Tested for Chrome.
  • - Tested for Safari.
  • - Go through the changed code looking for typos, TODOs, commented LOCs, debugging pieces of code, etc.
  • - Rebase your branch onto master and upstream branch
  • - Is there any redundant or duplicate code?
  • - Are required links are linked to PR?
  • - Does new code is well documented ?

Related issues

https://front.hc.engineering/workbench/platform/tracker/UBER-278

A list of closed updated issues

@ThetaDR
UBER-278: add Yes-No to popup, refactor
9fd24cd 
Signed-off-by: Vyacheslav Tumanov <me@slavatumanov.me>
@ThetaDR ThetaDR requested a review from BykhovDenis May 30, 2023 10:06
@ThetaDR
UBER-278: change presenter
18ed237 
Signed-off-by: Vyacheslav Tumanov <me@slavatumanov.me>
@ThetaDR
UBER-278: fix uitest
567d38c 
Signed-off-by: Vyacheslav Tumanov <me@slavatumanov.me>
@haiodo haiodo merged commit e0ea9fd into main May 30, 2023
@haiodo haiodo deleted the UBER-278 branch May 30, 2023 12:03
BykhovDenis pushed a commit that referenced this pull request May 31, 2023
@ThetaDR @BykhovDenis
UBER-278: add Yes-No to popup, refactor (#3289)
69bb062 
Signed-off-by: Vyacheslav Tumanov <me@slavatumanov.me>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haiodo haiodo haiodo approved these changes

@BykhovDenis BykhovDenis Awaiting requested review from BykhovDenis

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ThetaDR @haiodo