Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UBER-276: New messages and Has messages option for filter #3326

Merged
merged 2 commits into from
Jun 2, 2023
Merged

UBER-276: New messages and Has messages option for filter #3326

merged 2 commits into from
Jun 2, 2023

Conversation

ThetaDR
Copy link
Contributor

@ThetaDR ThetaDR commented Jun 1, 2023

Contribution checklist

Brief description

Checklist

  • - UI test added to added/changed functionality?
  • - Screenshot is added to PR if applicable ?
  • - Does the code work? Check whether function and logic are correct.
  • - Does Changelog.md is updated with changes?
  • - Does the translations are up to date?
  • - Does it well tested?
  • - Tested for Chrome.
  • - Tested for Safari.
  • - Go through the changed code looking for typos, TODOs, commented LOCs, debugging pieces of code, etc.
  • - Rebase your branch onto master and upstream branch
  • - Is there any redundant or duplicate code?
  • - Are required links are linked to PR?
  • - Does new code is well documented ?

Related issues

https://front.hc.engineering/workbench/platform/tracker/UBER-276
A list of closed updated issues

@ThetaDR
UBER-276: New messages and Has messages option for filter
f0d46f5 
Signed-off-by: Vyacheslav Tumanov <me@slavatumanov.me>
@ThetaDR ThetaDR requested a review from BykhovDenis June 1, 2023 14:41
BykhovDenis
BykhovDenis requested changes Jun 1, 2023
View reviewed changes
Copy link
Member

@BykhovDenis BykhovDenis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should add new filter modes

@ThetaDR
UBER-263: made it as mode
7c95f42 
Signed-off-by: Vyacheslav Tumanov <me@slavatumanov.me>
@ThetaDR ThetaDR requested a review from BykhovDenis June 2, 2023 13:11
@BykhovDenis BykhovDenis merged commit 4edbdc1 into main Jun 2, 2023
@haiodo haiodo deleted the UBER-276 branch June 23, 2023 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BykhovDenis BykhovDenis BykhovDenis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ThetaDR @BykhovDenis