Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UBER-691 #3564

Merged
merged 4 commits into from
Aug 7, 2023
Merged

UBER-691 #3564

merged 4 commits into from
Aug 7, 2023

Conversation

BykhovDenis
Copy link
Member

Contribution checklist

Brief description

Checklist

  • - UI test added to added/changed functionality?
  • - Screenshot is added to PR if applicable ?
  • - Does the code work? Check whether function and logic are correct.
  • - Does Changelog.md is updated with changes?
  • - Does the translations are up to date?
  • - Does it well tested?
  • - Tested for Chrome.
  • - Tested for Safari.
  • - Go through the changed code looking for typos, TODOs, commented LOCs, debugging pieces of code, etc.
  • - Rebase your branch onto master and upstream branch
  • - Is there any redundant or duplicate code?
  • - Are required links are linked to PR?
  • - Does new code is well documented ?

Related issues

A list of closed updated issues

@BykhovDenis BykhovDenis requested a review from haiodo August 7, 2023 09:14
@BykhovDenis BykhovDenis self-assigned this Aug 7, 2023
@BykhovDenis
UBER-691
7b40a09 
Signed-off-by: Denis Bykhov <bykhov.denis@gmail.com>
@BykhovDenis
Fix
ac420ed 
Signed-off-by: Denis Bykhov <bykhov.denis@gmail.com>
@BykhovDenis
Fix
1dd1c92 
Signed-off-by: Denis Bykhov <bykhov.denis@gmail.com>
@BykhovDenis
Fix
5ef0b46 
Signed-off-by: Denis Bykhov <bykhov.denis@gmail.com>
@haiodo haiodo merged commit 07cc690 into main Aug 7, 2023
@haiodo haiodo deleted the UBER-691 branch August 7, 2023 14:17
annano pushed a commit that referenced this pull request Aug 24, 2023
@BykhovDenis @annano
UBER-691 (#3564)
c21d06c 
Signed-off-by: Denis Bykhov <bykhov.denis@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haiodo haiodo haiodo approved these changes

Assignees

@BykhovDenis BykhovDenis

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BykhovDenis @haiodo