Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix for mixins for grouping by custom attributes #3898

Merged
merged 2 commits into from
Oct 29, 2023
Merged

fix for mixins for grouping by custom attributes #3898

merged 2 commits into from
Oct 29, 2023

Conversation

ThetaDR
Copy link
Contributor

@ThetaDR ThetaDR commented Oct 26, 2023

Contribution checklist

Brief description

Checklist

  • - UI test added to added/changed functionality?
  • - Screenshot is added to PR if applicable ?
  • - Does the code work? Check whether function and logic are correct.
  • - Does Changelog.md is updated with changes?
  • - Does the translations are up to date?
  • - Does it well tested?
  • - Tested for Chrome.
  • - Tested for Safari.
  • - Go through the changed code looking for typos, TODOs, commented LOCs, debugging pieces of code, etc.
  • - Rebase your branch onto master and upstream branch
  • - Is there any redundant or duplicate code?
  • - Are required links are linked to PR?
  • - Does new code is well documented ?

Related issues

A list of closed updated issues

@ThetaDR
fix for mixins for grouping by custom attributes
492353c 
Signed-off-by: Vyacheslav Tumanov <me@slavatumanov.me>
@ThetaDR ThetaDR requested a review from haiodo October 26, 2023 17:11
@ThetaDR ThetaDR self-assigned this Oct 26, 2023
@ThetaDR
Move hierarchy to mapping
515dbdc 
Signed-off-by: Vyacheslav Tumanov <me@slavatumanov.me>
@haiodo haiodo merged commit e158788 into main Oct 29, 2023
7 checks passed
@haiodo haiodo deleted the custom_attr_groupBy branch October 29, 2023 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haiodo haiodo haiodo approved these changes

Assignees

@ThetaDR ThetaDR

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ThetaDR @haiodo