Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EZQMS-430: Update change document owner popup UI #4278

Merged
merged 1 commit into from
Dec 27, 2023
Merged

EZQMS-430: Update change document owner popup UI #4278

merged 1 commit into from
Dec 27, 2023

Conversation

annano
Copy link
Contributor

@annano annano commented Dec 27, 2023 •
edited by SasLord
Loading

Contribution checklist

Brief description

Checklist

  • - UI test added to added/changed functionality?
  • - Screenshot is added to PR if applicable ?
  • - Does a local formatting is applied (rush format)
  • - Does a local svele-check is applied (rush svelte-check)
  • - Does a local UI tests are executed UI Testing
  • - Does the code work? Check whether function and logic are correct.
  • - Does Changelog.md is updated with changes?
  • - Does the translations are up to date?
  • - Does it well tested?
  • - Tested for Chrome.
  • - Tested for Safari.
  • - Go through the changed code looking for typos, TODOs, commented LOCs, debugging pieces of code, etc.
  • - Rebase your branch onto master and upstream branch
  • - Is there any redundant or duplicate code?
  • - Are required links are linked to PR?
  • - Does new code is well documented ?

Related issues

A list of closed updated issues

Contributor requirements

  • - Sign-off is provided. DCO
  • - GPG Signature is provided. GPG

Contribution checklist

Brief description

Checklist

  • - UI test added to added/changed functionality?
  • - Screenshot is added to PR if applicable ?
  • - Does a local formatting is applied (rush format)
  • - Does a local svele-check is applied (rush svelte-check)
  • - Does a local UI tests are executed UI Testing
  • - Does the code work? Check whether function and logic are correct.
  • - Does Changelog.md is updated with changes?
  • - Does the translations are up to date?
  • - Does it well tested?
  • - Tested for Chrome.
  • - Tested for Safari.
  • - Go through the changed code looking for typos, TODOs, commented LOCs, debugging pieces of code, etc.
  • - Rebase your branch onto master and upstream branch
  • - Is there any redundant or duplicate code?
  • - Are required links are linked to PR?
  • - Does new code is well documented ?

Related issues

A list of closed updated issues

Contributor requirements

  • - Sign-off is provided. DCO
  • - GPG Signature is provided. GPG

@annano
EZQMS-430: Update change document owner popup
d3786ee 
Signed-off-by: Anna No <anna.no@xored.com>
@annano annano merged commit 09579fd into main Dec 27, 2023
7 checks passed
@annano annano deleted the EZQMS-430/update-change-owner-popup branch December 27, 2023 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SasLord SasLord SasLord approved these changes

@aonnikov aonnikov Awaiting requested review from aonnikov

@lexiv0re lexiv0re Awaiting requested review from lexiv0re

@bellycat77 bellycat77 Awaiting requested review from bellycat77

@sol-0 sol-0 Awaiting requested review from sol-0

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@annano @SasLord