Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify #4354

Merged
merged 1 commit into from
Jan 13, 2024
Merged

Simplify #4354

merged 1 commit into from
Jan 13, 2024

Conversation

BykhovDenis
Copy link
Member

Contribution checklist

Brief description

Checklist

  • - UI test added to added/changed functionality?
  • - Screenshot is added to PR if applicable ?
  • - Does a local formatting is applied (rush format)
  • - Does a local svele-check is applied (rush svelte-check)
  • - Does a local UI tests are executed UI Testing
  • - Does the code work? Check whether function and logic are correct.
  • - Does Changelog.md is updated with changes?
  • - Does the translations are up to date?
  • - Does it well tested?
  • - Tested for Chrome.
  • - Tested for Safari.
  • - Go through the changed code looking for typos, TODOs, commented LOCs, debugging pieces of code, etc.
  • - Rebase your branch onto master and upstream branch
  • - Is there any redundant or duplicate code?
  • - Are required links are linked to PR?
  • - Does new code is well documented ?

Related issues

A list of closed updated issues

Contributor requirements

  • - Sign-off is provided. DCO
  • - GPG Signature is provided. GPG

Signed-off-by: Denis Bykhov <bykhov.denis@gmail.com>
@BykhovDenis BykhovDenis requested a review from haiodo January 13, 2024 14:16
@BykhovDenis BykhovDenis self-assigned this Jan 13, 2024
@haiodo haiodo merged commit 266b82e into main Jan 13, 2024
7 checks passed
@haiodo haiodo deleted the UBERF-4915_2 branch January 13, 2024 16:57
dm-parf pushed a commit to dm-parf/platform that referenced this pull request Jan 15, 2024
Signed-off-by: Denis Bykhov <bykhov.denis@gmail.com>
dm-parf pushed a commit to dm-parf/platform that referenced this pull request Jan 15, 2024
Signed-off-by: Denis Bykhov <bykhov.denis@gmail.com>
Signed-off-by: Dmitry <favoritegrech@yandex.ru>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants