Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: broken layout of action button #4514

Merged

Conversation

euaaaio
Copy link
Contributor

@euaaaio euaaaio commented Feb 4, 2024

Contribution checklist

Brief description

Based on the design, action buttons are usually placed last from the edge and work as a visual anchor to the action. So I rearranged the buttons. In addition, I fixed the margins between them similar to other pages.

Screenshot

Screenshot 2024-02-04 at 20 40 26

Checklist

  • - UI test added to added/changed functionality?
  • - Screenshot is added to PR if applicable ?
  • - Does a local formatting is applied (rush format)
  • - Does a local svelte-check is applied (rush svelte-check)
  • - Does a local UI tests are executed UI Testing
  • - Does the code work? Check whether function and logic are correct.
  • - Does Changelog.md is updated with changes?
  • - Does the translations are up to date?
  • - Does it well tested?
  • - Tested for Chrome.
  • - Tested for Safari.
  • - Go through the changed code looking for typos, TODOs, commented LOCs, debugging pieces of code, etc.
  • - Rebase your branch onto master and upstream branch
  • - Is there any redundant or duplicate code?
  • - Are required links are linked to PR?
  • - Does new code is well documented ?

Related issues

Resolves #4513

Contributor requirements

  • - Sign-off is provided. DCO
  • - GPG Signature is provided. GPG

Signed-off-by: Eduard Aksamitov <e@euaaaio.ru>
@haiodo haiodo requested a review from SasLord February 5, 2024 08:52
@BykhovDenis BykhovDenis merged commit 9baa011 into hcengineering:main Feb 7, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Broken layout of action button on some pages
3 participants