Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Select workspace fixes #4701

Merged
merged 2 commits into from
Feb 20, 2024
Merged

Select workspace fixes #4701

merged 2 commits into from
Feb 20, 2024

Conversation

BykhovDenis
Copy link
Member

@BykhovDenis BykhovDenis commented Feb 19, 2024 •
edited by haiodo
Loading

Contribution checklist

Brief description

Checklist

  • - UI test added to added/changed functionality?
  • - Screenshot is added to PR if applicable ?
  • - Does a local formatting is applied (rush format)
  • - Does a local svelte-check is applied (rush svelte-check)
  • - Does a local UI tests are executed UI Testing
  • - Does the code work? Check whether function and logic are correct.
  • - Does Changelog.md is updated with changes?
  • - Does the translations are up to date?
  • - Does it well tested?
  • - Tested for Chrome.
  • - Tested for Safari.
  • - Go through the changed code looking for typos, TODOs, commented LOCs, debugging pieces of code, etc.
  • - Rebase your branch onto master and upstream branch
  • - Is there any redundant or duplicate code?
  • - Are required links are linked to PR?
  • - Does new code is well documented ?

Related issues

A list of closed updated issues

Contributor requirements

  • - Sign-off is provided. DCO
  • - GPG Signature is provided. GPG

@BykhovDenis
Select workspace fixes
ddab998 
Signed-off-by: Denis Bykhov <bykhov.denis@gmail.com>
@BykhovDenis BykhovDenis requested a review from haiodo February 19, 2024 10:15
@BykhovDenis BykhovDenis self-assigned this Feb 19, 2024
haiodo
haiodo previously approved these changes Feb 19, 2024
View reviewed changes
@BykhovDenis
Fix tests
e1808a9 
Signed-off-by: Denis Bykhov <bykhov.denis@gmail.com>
@haiodo haiodo merged commit b9fd44c into main Feb 20, 2024
7 checks passed
@haiodo haiodo deleted the select_workspace_fixes branch February 20, 2024 15:18
tjaoc pushed a commit to tjaoc/huly that referenced this pull request Mar 5, 2024
@BykhovDenis @tjaoc
Select workspace fixes (hcengineering#4701)
a449679 
Signed-off-by: Denis Bykhov <bykhov.denis@gmail.com>
Signed-off-by: Tiago Cruz <tcruz@netic.io>
tjaoc pushed a commit to tjaoc/huly that referenced this pull request Mar 5, 2024
@BykhovDenis @tjaoc
Select workspace fixes (hcengineering#4701)
6646242 
Signed-off-by: Denis Bykhov <bykhov.denis@gmail.com>
Signed-off-by: Tiago Cruz <tcruz@netic.io>
tjaoc pushed a commit to tjaoc/huly that referenced this pull request Mar 7, 2024
@BykhovDenis @tjaoc
Select workspace fixes (hcengineering#4701)
21ee9e0 
Signed-off-by: Denis Bykhov <bykhov.denis@gmail.com>
Signed-off-by: Tiago Cruz <tcruz@netic.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haiodo haiodo haiodo approved these changes

Assignees

@BykhovDenis BykhovDenis

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BykhovDenis @haiodo