Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UBERF-5603 #4754

Merged
merged 7 commits into from
Feb 23, 2024
Merged

UBERF-5603 #4754

merged 7 commits into from
Feb 23, 2024

Conversation

BykhovDenis
Copy link
Member

@BykhovDenis BykhovDenis commented Feb 22, 2024 •
edited
Loading

Contribution checklist

Brief description

Checklist

  • - UI test added to added/changed functionality?
  • - Screenshot is added to PR if applicable ?
  • - Does a local formatting is applied (rush format)
  • - Does a local svelte-check is applied (rush svelte-check)
  • - Does a local UI tests are executed UI Testing
  • - Does the code work? Check whether function and logic are correct.
  • - Does Changelog.md is updated with changes?
  • - Does the translations are up to date?
  • - Does it well tested?
  • - Tested for Chrome.
  • - Tested for Safari.
  • - Go through the changed code looking for typos, TODOs, commented LOCs, debugging pieces of code, etc.
  • - Rebase your branch onto master and upstream branch
  • - Is there any redundant or duplicate code?
  • - Are required links are linked to PR?
  • - Does new code is well documented ?

Related issues

A list of closed updated issues

Contributor requirements

  • - Sign-off is provided. DCO
  • - GPG Signature is provided. GPG

@BykhovDenis BykhovDenis requested a review from haiodo February 22, 2024 15:23
@BykhovDenis BykhovDenis self-assigned this Feb 22, 2024
@haiodo haiodo marked this pull request as draft February 22, 2024 17:04
@haiodo haiodo marked this pull request as ready for review February 22, 2024 17:04
@BykhovDenis BykhovDenis force-pushed the UBERF-5603 branch 3 times, most recently from 3cb203d to 611e493 Compare February 23, 2024 07:32
@BykhovDenis
UBERF-5603
77dff28 
Signed-off-by: Denis Bykhov <bykhov.denis@gmail.com>
@BykhovDenis
Fixes
cfea915 
Signed-off-by: Denis Bykhov <bykhov.denis@gmail.com>
@BykhovDenis
Update packages
d2f58dd 
Signed-off-by: Denis Bykhov <bykhov.denis@gmail.com>
@BykhovDenis
Fix formatting
badf269 
Signed-off-by: Denis Bykhov <bykhov.denis@gmail.com>
@BykhovDenis
Fix tests
fb46111 
Signed-off-by: Denis Bykhov <bykhov.denis@gmail.com>
@BykhovDenis
Fix
9517587 
Signed-off-by: Denis Bykhov <bykhov.denis@gmail.com>
@BykhovDenis
One more
89a2c14 
Signed-off-by: Denis Bykhov <bykhov.denis@gmail.com>
@haiodo haiodo merged commit ffc8d1d into main Feb 23, 2024
7 checks passed
@haiodo haiodo deleted the UBERF-5603 branch February 23, 2024 08:39
tjaoc pushed a commit to tjaoc/huly that referenced this pull request Mar 5, 2024
@BykhovDenis @tjaoc
UBERF-5603 (hcengineering#4754)
0f6cd36 
Signed-off-by: Denis Bykhov <bykhov.denis@gmail.com>
Signed-off-by: Tiago Cruz <tcruz@netic.io>
tjaoc pushed a commit to tjaoc/huly that referenced this pull request Mar 5, 2024
@BykhovDenis @tjaoc
UBERF-5603 (hcengineering#4754)
b91a549 
Signed-off-by: Denis Bykhov <bykhov.denis@gmail.com>
Signed-off-by: Tiago Cruz <tcruz@netic.io>
tjaoc pushed a commit to tjaoc/huly that referenced this pull request Mar 7, 2024
@BykhovDenis @tjaoc
UBERF-5603 (hcengineering#4754)
dad9b9f 
Signed-off-by: Denis Bykhov <bykhov.denis@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haiodo haiodo haiodo approved these changes

Assignees

@BykhovDenis BykhovDenis

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BykhovDenis @haiodo