Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UBER-1239: fix missing notifications for mentions from doc #4820

Merged
merged 1 commit into from
Feb 29, 2024
Merged

UBER-1239: fix missing notifications for mentions from doc #4820

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions server-plugins/notification-resources/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -584,6 +584,15 @@ export async function createCollabDocInfo (
}

const targets = new Set(collaborators)

// user is not collaborator of himself, but we should notify user of changes related to users account (mentions, comments etc)
if (control.hierarchy.isDerived(object._class, contact.class.Person)) {
const acc = await getPersonAccount(object._id as Ref<Person>, control)
if (acc !== undefined) {
targets.add(acc._id)
}
}

const notifyContexts = await control.findAll(notification.class.DocNotifyContext, {
attachedTo: { $in: activityMessage.map(({ attachedTo }) => attachedTo) }
})
Expand Down
Loading