Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UBERF-5650: do not send mention notification if user already notified #4821

Merged
merged 1 commit into from
Feb 29, 2024
Merged

UBERF-5650: do not send mention notification if user already notified #4821

merged 1 commit into from
Feb 29, 2024

Conversation

kristina-fefelova
Copy link
Member

@kristina-fefelova kristina-fefelova commented Feb 29, 2024 •
edited
Loading

Contribution checklist

Brief description

Checklist

  • - UI test added to added/changed functionality?
  • - Screenshot is added to PR if applicable ?
  • - Does a local formatting is applied (rush format)
  • - Does a local svelte-check is applied (rush svelte-check)
  • - Does a local UI tests are executed UI Testing
  • - Does the code work? Check whether function and logic are correct.
  • - Does Changelog.md is updated with changes?
  • - Does the translations are up to date?
  • - Does it well tested?
  • - Tested for Chrome.
  • - Tested for Safari.
  • - Go through the changed code looking for typos, TODOs, commented LOCs, debugging pieces of code, etc.
  • - Rebase your branch onto master and upstream branch
  • - Is there any redundant or duplicate code?
  • - Are required links are linked to PR?
  • - Does new code is well documented ?

Related issues

A list of closed updated issues

Contributor requirements

  • - Sign-off is provided. DCO
  • - GPG Signature is provided. GPG

@kristina-fefelova
UBERF-5650: do not send mention notification if user already notified
67c0715 
Signed-off-by: Kristina Fefelova <kristin.fefelova@gmail.com>
@haiodo haiodo merged commit a835180 into main Feb 29, 2024
7 checks passed
@haiodo haiodo deleted the fix-double-notification-5650 branch February 29, 2024 06:31
tjaoc pushed a commit to tjaoc/huly that referenced this pull request Mar 5, 2024
@kristina-fefelova @tjaoc
UBERF-5650: do not send mention notification if user already notified (…
45df941 
…hcengineering#4821)

Signed-off-by: Kristina Fefelova <kristin.fefelova@gmail.com>
Signed-off-by: Tiago Cruz <tcruz@netic.io>
tjaoc pushed a commit to tjaoc/huly that referenced this pull request Mar 5, 2024
@kristina-fefelova @tjaoc
UBERF-5650: do not send mention notification if user already notified (…
9f90703 
…hcengineering#4821)

Signed-off-by: Kristina Fefelova <kristin.fefelova@gmail.com>
Signed-off-by: Tiago Cruz <tcruz@netic.io>
tjaoc pushed a commit to tjaoc/huly that referenced this pull request Mar 5, 2024
@kristina-fefelova @tjaoc
UBERF-5650: do not send mention notification if user already notified (…
f207565 
…hcengineering#4821)

Signed-off-by: Kristina Fefelova <kristin.fefelova@gmail.com>
Signed-off-by: Tiago Cruz <tcruz@netic.io>
tjaoc pushed a commit to tjaoc/huly that referenced this pull request Mar 5, 2024
@kristina-fefelova @tjaoc
UBERF-5650: do not send mention notification if user already notified (…
38bad56 
…hcengineering#4821)

Signed-off-by: Kristina Fefelova <kristin.fefelova@gmail.com>
Signed-off-by: Tiago Cruz <tcruz@netic.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haiodo haiodo haiodo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kristina-fefelova @haiodo