Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: label count in issue template #7555

Merged
merged 2 commits into from
Jan 3, 2025

Conversation

dakshesh14
Copy link
Contributor

@dakshesh14 dakshesh14 commented Dec 25, 2024

Fix:

  • Resolves an issue where the label count was incorrectly incremented in the issue template, even when a label was deselected.
  • Addresses #7530

Before:

before-label-count.webm

After:

after-label-count.webm

Huly®: UBERF-9024

Signed-off-by: Dakshesh Jain <dakshesh.jain14@gmail.com>
@dakshesh14
Copy link
Contributor Author

Hi team, this PR fixes the issue, but I noticed that the component's types and usage configurations might need a closer look. Since I don’t have deep knowledge of the component, I focused on making minimal changes to address the problem. Let me know your thoughts!

Signed-off-by: Dakshesh Jain <dakshesh.jain14@gmail.com>
@dakshesh14
Copy link
Contributor Author

Hi @haiodo, I noticed a few pipelines are failing. Should I look into them? If so, could you guide me on how to run these locally? I tried using the command from the pipeline 'Details' but ran into some issues—perhaps I’m missing something. Thanks!

@haiodo
Copy link
Member

haiodo commented Jan 1, 2025

They are a bit flaky, you could if you have some time, thanks.

@dakshesh14
Copy link
Contributor Author

I was wondering if we can merge my PR. I can probably look into test-cases in a different PR if they are flaky.

@haiodo haiodo merged commit 5becc41 into hcengineering:develop Jan 3, 2025
10 checks passed
@dakshesh14 dakshesh14 deleted the fix/template-label-count branch January 3, 2025 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants