Skip to content

Update card trigger #9579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 22, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
110 changes: 96 additions & 14 deletions models/process/src/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,7 @@ import {
type ExecutionLogAction,
type ExecutionStatus,
type Method,
type MethodParams,
type Process,
type ProcessContext,
type ProcessFunction,
Expand All @@ -59,6 +60,7 @@ import {
type Step,
type Transition,
type Trigger,
type UpdateCriteriaComponent,
processId
} from '@hcengineering/process'
import time from '@hcengineering/time'
Expand Down Expand Up @@ -98,6 +100,8 @@ export class TTrigger extends TDoc implements Trigger {

editor?: AnyComponent

presenter?: AnyComponent

icon!: Asset

requiredParams!: string[]
Expand Down Expand Up @@ -200,6 +204,8 @@ export class TMethod extends TDoc implements Method<Doc> {
presenter?: AnyComponent

requiredParams!: string[]

defaultParams?: MethodParams<Doc>
}

@Model(process.class.State, core.class.Doc, DOMAIN_MODEL)
Expand All @@ -218,6 +224,15 @@ export class TProcessFunction extends TDoc implements ProcessFunction {
type!: 'transform' | 'reduce' | 'context'
}

@Model(process.class.UpdateCriteriaComponent, core.class.Doc, DOMAIN_MODEL)
export class TUpdateCriteriaComponent extends TDoc implements UpdateCriteriaComponent {
category!: AttributeCategory

editor!: AnyComponent

of!: Ref<Class<Doc<Space>>>
}

export * from './migration'

export function createModel (builder: Builder): void {
Expand All @@ -230,7 +245,8 @@ export function createModel (builder: Builder): void {
TProcessFunction,
TTransition,
TTrigger,
TExecutionLog
TExecutionLog,
TUpdateCriteriaComponent
)

createAction(builder, {
Expand Down Expand Up @@ -871,7 +887,10 @@ export function createModel (builder: Builder): void {
objectClass: process.class.ProcessToDo,
presenter: process.component.ToDoPresenter,
contextClass: process.class.ProcessToDo,
requiredParams: ['state', 'title', 'user']
requiredParams: ['state', 'title', 'user'],
defaultParams: {
withRollback: true
}
},
process.method.CreateToDo
)
Expand Down Expand Up @@ -930,18 +949,6 @@ export function createModel (builder: Builder): void {
process.method.AddRelation
)

builder.createDoc(
process.class.Trigger,
core.space.Model,
{
label: process.string.OnSubProcessesDone,
icon: process.icon.WaitSubprocesses,
requiredParams: [],
init: false
},
process.trigger.OnSubProcessesDone
)

builder.createDoc(
process.class.Trigger,
core.space.Model,
Expand Down Expand Up @@ -970,6 +977,33 @@ export function createModel (builder: Builder): void {
process.trigger.OnToDoRemove
)

builder.createDoc(
process.class.Trigger,
core.space.Model,
{
label: process.string.OnCardUpdate,
icon: process.icon.OnCardUpdate,
editor: process.component.CardUpdateEditor,
presenter: process.component.CardUpdatePresenter,
requiredParams: [],
checkFunction: process.triggerCheck.UpdateCheck,
init: false
},
process.trigger.OnCardUpdate
)

builder.createDoc(
process.class.Trigger,
core.space.Model,
{
label: process.string.OnSubProcessesDone,
icon: process.icon.WaitSubprocesses,
requiredParams: [],
init: false
},
process.trigger.OnSubProcessesDone
)

builder.createDoc(card.class.MasterTagEditorSection, core.space.Model, {
id: 'processes',
label: process.string.Processes,
Expand All @@ -980,6 +1014,54 @@ export function createModel (builder: Builder): void {
extension: workbench.extensions.WorkbenchExtensions,
component: process.component.NotifierExtension
})

builder.createDoc(process.class.UpdateCriteriaComponent, core.space.Model, {
category: 'attribute',
editor: process.criteriaEditor.StringCriteria,
of: core.class.TypeString
})

builder.createDoc(process.class.UpdateCriteriaComponent, core.space.Model, {
category: 'attribute',
editor: process.criteriaEditor.StringCriteria,
of: core.class.TypeHyperlink
})

builder.createDoc(process.class.UpdateCriteriaComponent, core.space.Model, {
category: 'attribute',
editor: process.criteriaEditor.NumberCriteria,
of: core.class.TypeNumber
})

builder.createDoc(process.class.UpdateCriteriaComponent, core.space.Model, {
category: 'attribute',
editor: process.criteriaEditor.DateCriteria,
of: core.class.TypeDate
})

builder.createDoc(process.class.UpdateCriteriaComponent, core.space.Model, {
category: 'attribute',
editor: process.criteriaEditor.BooleanCriteria,
of: core.class.TypeBoolean
})

builder.createDoc(process.class.UpdateCriteriaComponent, core.space.Model, {
category: 'array',
editor: process.criteriaEditor.ArrayCriteria,
of: core.class.ArrOf
})

builder.createDoc(process.class.UpdateCriteriaComponent, core.space.Model, {
category: 'attribute',
editor: process.criteriaEditor.EnumCriteria,
of: core.class.EnumOf
})

builder.createDoc(process.class.UpdateCriteriaComponent, core.space.Model, {
category: 'object',
editor: process.criteriaEditor.RefCriteria,
of: core.class.RefTo
})
}

export { processId } from '@hcengineering/process'
Expand Down
25 changes: 24 additions & 1 deletion models/server-process/src/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
// See the License for the specific language governing permissions and
// limitations under the License.

import cardPlugin from '@hcengineering/card'
import core, { type Doc } from '@hcengineering/core'
import { Mixin, type Builder } from '@hcengineering/model'
import { TMethod, TProcessFunction, TTrigger } from '@hcengineering/model-process'
Expand All @@ -28,7 +29,7 @@ import serverProcess, {
export { serverProcessId } from '@hcengineering/server-process'

@Mixin(serverProcess.mixin.MethodImpl, process.class.Method)
export class TMethodImpl<T extends Doc> extends TMethod implements MethodImpl<T> {
export class TMethodImpl extends TMethod implements MethodImpl<Doc> {
func!: Resource<ExecuteFunc>
}

Expand All @@ -53,6 +54,10 @@ export function createModel (builder: Builder): void {
serverCheckFunc: serverProcess.func.CheckToDo
})

builder.mixin(process.trigger.OnCardUpdate, process.class.Trigger, serverProcess.mixin.TriggerImpl, {
serverCheckFunc: serverProcess.func.OnCardUpdateCheck
})

builder.mixin(process.method.RunSubProcess, process.class.Method, serverProcess.mixin.MethodImpl, {
func: serverProcess.func.RunSubProcess
})
Expand Down Expand Up @@ -214,6 +219,24 @@ export function createModel (builder: Builder): void {
isAsync: true
})

builder.createDoc(serverCore.class.Trigger, core.space.Model, {
trigger: serverProcess.trigger.OnCardUpdate,
txMatch: {
_class: core.class.TxUpdateDoc,
objectClass: cardPlugin.class.Card
}
})

builder.createDoc(serverCore.class.Trigger, core.space.Model, {
trigger: serverProcess.trigger.OnExecutionTransition,
txMatch: {
_class: core.class.TxUpdateDoc,
objectClass: process.class.Execution,
'operations.currentState': { $exists: true }
},
isAsync: true
})

builder.createDoc(serverCore.class.Trigger, core.space.Model, {
trigger: serverProcess.trigger.OnProcessRemove,
txMatch: {
Expand Down
11 changes: 9 additions & 2 deletions packages/core/src/predicate.ts
Original file line number Diff line number Diff line change
Expand Up @@ -67,8 +67,15 @@ const predicates: Record<string, PredicateFactory> = {
if (!Array.isArray(o)) {
throw new Error('$nin predicate requires array')
}
// eslint-disable-next-line eqeqeq
return (docs) => execPredicate(docs, propertyKey, (value) => !o.some((p) => p == value))
return (docs) =>
execPredicate(docs, propertyKey, (value) => {
if (Array.isArray(value)) {
return !o.some((p) => value.includes(p))
} else {
// eslint-disable-next-line eqeqeq
return !o.some((p) => p == value)
}
})
},

$like: (query: string, propertyKey: string): Predicate => {
Expand Down
30 changes: 18 additions & 12 deletions packages/presentation/src/utils.ts
Original file line number Diff line number Diff line change
Expand Up @@ -736,17 +736,17 @@ export function getAttrEditor (type: Type<any>, hierarchy: Hierarchy): AnyCompon
return editorMixin?.inlineEditor
}

export async function getAttributeEditor (
export function findAttributeEditor (
client: Client,
_class: Ref<Class<Obj>>,
key: KeyedAttribute | string
): Promise<AnySvelteComponent | undefined> {
): AnyComponent | undefined {
const hierarchy = client.getHierarchy()
const attribute = typeof key === 'string' ? hierarchy.getAttribute(_class, key) : key.attr

if (attribute.type._class === core.class.TypeAny) {
const _type: TypeAny = attribute.type as TypeAny<AnyComponent>
return await getResource(_type.editor ?? _type.presenter)
return _type.editor ?? _type.presenter
}

const presenterClass = attribute !== undefined ? getAttributePresenterClass(hierarchy, attribute.type) : undefined
Expand All @@ -772,11 +772,7 @@ export async function getAttributeEditor (
}

if (attribute.editor != null) {
try {
return await getResource(attribute.editor)
} catch (ex) {
console.error(getAttributeEditorNotFoundError(_class, key, ex))
}
return attribute.editor
}
const editorMixin = hierarchy.classHierarchyMixin(presenterClass.attrClass, mixin)

Expand All @@ -788,11 +784,21 @@ export async function getAttributeEditor (
// }
return
}
return editorMixin.inlineEditor
}

try {
return await getResource(editorMixin.inlineEditor)
} catch (ex) {
console.error(getAttributeEditorNotFoundError(_class, key, ex))
export async function getAttributeEditor (
client: Client,
_class: Ref<Class<Obj>>,
key: KeyedAttribute | string
): Promise<AnySvelteComponent | undefined> {
const value = findAttributeEditor(client, _class, key)
if (value !== undefined) {
try {
return await getResource(value)
} catch (ex) {
console.error(getAttributeEditorNotFoundError(_class, key, ex))
}
}
}

Expand Down
6 changes: 6 additions & 0 deletions plugins/process-assets/assets/icons.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
6 changes: 4 additions & 2 deletions plugins/process-assets/lang/cs.json
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,8 @@
"LogAction": "Událost",
"Started": "Spuštěno",
"Each": "Každý",
"CreateCard": "Vytvořit kartu"
"CreateCard": "Vytvořit kartu",
"OnCardUpdate": "Při aktualizaci karty"
},
"error": {
"MethodNotFound": "Metoda nenalezena: {methodId}",
Expand All @@ -105,6 +106,7 @@
"ResultNotProvided": "Výsledek nebyl poskytnut",
"EmptyFunctionResult": "Prázdný výsledek funkce {func}",
"ContextValueNotProvided": "Hodnota kontextu nebyla poskytnuta: {name}",
"RequiredParamsNotProvided": "Chybí požadované parametry: {params}"
"RequiredParamsNotProvided": "Chybí požadované parametry: {params}",
"TooDeepTransitionRecursion": "Příliš hluboká rekurze přechodů"
}
}
6 changes: 4 additions & 2 deletions plugins/process-assets/lang/de.json
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,8 @@
"LogAction": "Ereignis",
"Started": "Gestartet",
"Each": "Jeder",
"CreateCard": "Karte erstellen"
"CreateCard": "Karte erstellen",
"OnCardUpdate": "Beim Aktualisieren der Karte"
},
"error": {
"MethodNotFound": "Methode nicht gefunden: {methodId}",
Expand All @@ -105,6 +106,7 @@
"ResultNotProvided": "Ergebnis nicht bereitgestellt",
"EmptyFunctionResult": "Leerer Funktionsresultat {func}",
"ContextValueNotProvided": "Kontextwert nicht bereitgestellt: {name}",
"RequiredParamsNotProvided": "Erforderliche Parameter nicht bereitgestellt: {params}"
"RequiredParamsNotProvided": "Erforderliche Parameter nicht bereitgestellt: {params}",
"TooDeepTransitionRecursion": "Zu tiefe Übergangsrekursion"
}
}
6 changes: 4 additions & 2 deletions plugins/process-assets/lang/en.json
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,8 @@
"LogAction": "Event",
"Started": "Started",
"Each": "Each",
"CreateCard": "Create card"
"CreateCard": "Create card",
"OnCardUpdate": "On card update"
},
"error": {
"MethodNotFound": "Method not found: {methodId}",
Expand All @@ -105,6 +106,7 @@
"ResultNotProvided": "Result not provided",
"EmptyFunctionResult": "Empty function result {func}",
"ContextValueNotProvided": "Context value not provided: {name}",
"RequiredParamsNotProvided": "Required parameters not provided: {params}"
"RequiredParamsNotProvided": "Required parameters not provided: {params}",
"TooDeepTransitionRecursion": "Too deep transition recursion"
}
}
6 changes: 4 additions & 2 deletions plugins/process-assets/lang/es.json
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,8 @@
"LogAction": "Evento",
"Started": "Iniciado",
"Each": "Cada",
"CreateCard": "Crear tarjeta"
"CreateCard": "Crear tarjeta",
"OnCardUpdate": "Al actualizar la tarjeta"
},
"error": {
"MethodNotFound": "Método no encontrado: {methodId}",
Expand All @@ -105,6 +106,7 @@
"ResultNotProvided": "Resultado no proporcionado",
"EmptyFunctionResult": "Resultado de función vacío {func}",
"ContextValueNotProvided": "Valor de contexto no proporcionado: {name}",
"RequiredParamsNotProvided": "Faltan parámetros requeridos: {params}"
"RequiredParamsNotProvided": "Faltan parámetros requeridos: {params}",
"TooDeepTransitionRecursion": "Demasiada recursión de transición"
}
}
Loading
Loading