Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

astpath recent upgrade breaks bellybutton lint #19

Open
nanorepublica opened this issue Jan 14, 2019 · 4 comments
Open

astpath recent upgrade breaks bellybutton lint #19

nanorepublica opened this issue Jan 14, 2019 · 4 comments
Assignees
Labels
bug Something isn't working

Comments

@nanorepublica
Copy link

Hi

One of your dependencies astpath upgraded on Friday and removed an argument return_lines from find_in_ast function call.

The lines concerned are https://github.com/hchasestevens/bellybutton/blob/master/bellybutton/linting.py#L57

and

https://github.com/hchasestevens/bellybutton/blob/master/bellybutton/parsing.py#L137

a simple fix would be to fix the version of astpath until a full change can be made.

Thanks

hchasestevens added a commit that referenced this issue Jan 14, 2019
@hchasestevens
Copy link
Owner

Hi @nanorepublica , thanks for bringing this to my attention. I've pegged the version of astpath used to 0.6.1. Can you please confirm that this has fixed the issue temporarily?

@hchasestevens hchasestevens self-assigned this Jan 14, 2019
@hchasestevens hchasestevens added the bug Something isn't working label Jan 14, 2019
@mozz100
Copy link

mozz100 commented Jan 14, 2019

Hi @hchasestevens and thanks for the quick response on this. I work with @nanorepublica and we have just confirmed that updating to bellybutton 0.2.4 gets things working again.

Regards

Richard

@hchasestevens
Copy link
Owner

@mozz100 Thanks for confirming. I'll look to release a proper fix soon. Apologies for any inconvenience.

@moagstar
Copy link

Thanks for this great little tool! It would be nice to get a proper fix for this, I would like to use the regular expression functionality in a bellybutton rule. If you have an idea of what is needed to fix this properly I would be happy to help out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants