Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump pyyaml and specify explicit FullLoader for yaml #24

Merged
merged 2 commits into from
Dec 9, 2019

Conversation

palicand
Copy link
Contributor

@palicand palicand commented Dec 6, 2019

Version for pyyaml has been restricted because it has started to require
an explicit loader for loading yaml files (see #20).
By applying this commit, we can now remove the restriction,
since we explicitly specify the loader.

We had to bump the lower bound for pyyaml to >=4.0 because 3.x versions did not have a FullLoader, which is required for this to work properly.

Version for pyyaml has been restricted because it
has started to require an explicit loader for loading
yaml files. By appliying this commit, we can now remove
the restriction, since we explicitly specify the loader.
@hchasestevens
Copy link
Owner

Hi @palicand, thank you for the contribution. Would you mind also bumping the setup.py version to 0.3.0 as part of this PR?

@palicand
Copy link
Contributor Author

palicand commented Dec 9, 2019

Hi, not at all. I’ll bump it later today.

@palicand
Copy link
Contributor Author

palicand commented Dec 9, 2019

Hi @palicand, thank you for the contribution. Would you mind also bumping the setup.py version to 0.3.0 as part of this PR?

Version bumped, please review :-)

Copy link
Owner

@hchasestevens hchasestevens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Thanks for the contribution. I will push the updated version to pypi in short order.

@hchasestevens hchasestevens merged commit 465ac65 into hchasestevens:master Dec 9, 2019
@hchasestevens
Copy link
Owner

@palicand I've released 0.3.0 -- thanks again for the PR!

@palicand
Copy link
Contributor Author

@hchasestevens thanks for the merge and quick release!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants