Fix warnings in tests and compile tests #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes a bunch of warnings like:
test/test-highlighting.el:1:1: Warning: file has no ‘lexical-binding’ directive on its first line
It's available as part of Emacs distribution since version 24, and hcl-mode already requires at least 24.3.
The packages initialization is only needed by linting target.
Hi-Angel
force-pushed
the
fix-warnings
branch
2 times, most recently
from
c41e60f to
bb13e03
Compare
|
Hmm… It turns out |
Hi-Angel
force-pushed
the
fix-warnings
branch
from
bb13e03 to
561a423
Compare
|
@tgross 24.3 byte-compilation seems to be broken, because it prints warnings about unused values that seem to be completely spurious, the code it complains about does not even have a But I'm wondering, what's the point of having two 24-th versions of Emacs? There're both 24.3 and 24.5. And the latter seems to have the bug fixed. Rather than creating workarounds, I suggest to just drop 24.3 from the testing matrix, what do you think? |
Hi-Angel
force-pushed
the
fix-warnings
branch
from
561a423 to
1ef6e88
Compare
|
Ping |
2 similar comments
|
Ping |
|
Ping |
|
ping 4 |
|
@Hi-Angel please stop pinging to fire notifications. This repo is volunteer-run, and folks will review when they have time. |
|
@tgross that's 4 pings in 3 months. Infrequent ping is usually fine and encouraged because people tend to forget stuff. |
|
…it is typically fine to ping once a week, so 4 pings in 3 months is very little. |
purcell
reviewed
Oct 14, 2024
There was a problem hiding this comment.
I think here I'd probably switch to my fairly-standard Makefile structure, e.g. as used here, and also try to add package-lint to the CI config.
Personal preference would be to not add any code to ensure Emacs 24 compatibility, because that version is super old now.
Fixes warnings:
In toplevel form:
test/test-command.el: Warning: ‘font-lock-fontify-buffer’ is for interactive use only; use ‘font-lock-ensure’ or ‘font-lock-flush’ instead.
test/test-command.el: Warning: ‘font-lock-fontify-buffer’ is for interactive use only; use ‘font-lock-ensure’ or ‘font-lock-flush’ instead.
In toplevel form:
test/test-highlighting.el:32:7: Warning: ‘font-lock-fontify-buffer’ is for interactive use only; use ‘font-lock-ensure’ or ‘font-lock-flush’ instead.
test/test-highlighting.el: Warning: ‘font-lock-fontify-buffer’ is for interactive use only; use ‘font-lock-ensure’ or ‘font-lock-flush’ instead.
test/test-highlighting.el: Warning: ‘font-lock-fontify-buffer’ is for interactive use only; use ‘font-lock-ensure’ or ‘font-lock-flush’ instead.
test/test-highlighting.el: Warning: ‘font-lock-fontify-buffer’ is for interactive use only; use ‘font-lock-ensure’ or ‘font-lock-flush’ instead.
test/test-highlighting.el: Warning: ‘font-lock-fontify-buffer’ is for interactive use only; use ‘font-lock-ensure’ or ‘font-lock-flush’ instead.
test/test-highlighting.el: Warning: ‘font-lock-fontify-buffer’ is for interactive use only; use ‘font-lock-ensure’ or ‘font-lock-flush’ instead.
test/test-highlighting.el: Warning: ‘font-lock-fontify-buffer’ is for interactive use only; use ‘font-lock-ensure’ or ‘font-lock-flush’ instead.
test/test-highlighting.el: Warning: ‘font-lock-fontify-buffer’ is for interactive use only; use ‘font-lock-ensure’ or ‘font-lock-flush’ instead.
test/test-highlighting.el: Warning: ‘font-lock-fontify-buffer’ is for interactive use only; use ‘font-lock-ensure’ or ‘font-lock-flush’ instead.
test/test-highlighting.el: Warning: ‘font-lock-fontify-buffer’ is for interactive use only; use ‘font-lock-ensure’ or ‘font-lock-flush’ instead.
test/test-highlighting.el: Warning: ‘font-lock-fontify-buffer’ is for interactive use only; use ‘font-lock-ensure’ or ‘font-lock-flush’ instead.
test/test-highlighting.el: Warning: ‘font-lock-fontify-buffer’ is for interactive use only; use ‘font-lock-ensure’ or ‘font-lock-flush’ instead.
In toplevel form:
test/test-indentation.el: Warning: ‘font-lock-fontify-buffer’ is for interactive use only; use ‘font-lock-ensure’ or ‘font-lock-flush’ instead.
test/test-indentation.el: Warning: ‘font-lock-fontify-buffer’ is for interactive use only; use ‘font-lock-ensure’ or ‘font-lock-flush’ instead.
test/test-indentation.el: Warning: ‘font-lock-fontify-buffer’ is for interactive use only; use ‘font-lock-ensure’ or ‘font-lock-flush’ instead.
test/test-indentation.el: Warning: ‘font-lock-fontify-buffer’ is for interactive use only; use ‘font-lock-ensure’ or ‘font-lock-flush’ instead.
test/test-indentation.el: Warning: ‘font-lock-fontify-buffer’ is for interactive use only; use ‘font-lock-ensure’ or ‘font-lock-flush’ instead.
test/test-indentation.el: Warning: ‘font-lock-fontify-buffer’ is for interactive use only; use ‘font-lock-ensure’ or ‘font-lock-flush’ instead.
test/test-indentation.el: Warning: ‘font-lock-fontify-buffer’ is for interactive use only; use ‘font-lock-ensure’ or ‘font-lock-flush’ instead.
This fixes compilation warnings:
In end of data:
test/test-command.el:41:6: Warning: the function ‘forward-cursor-on’ is not known to be defined.
test/test-command.el:29:4: Warning: the function ‘with-hcl-temp-buffer’ is not known to be defined.
In end of data:
test/test-highlighting.el:42:6: Warning: the function ‘forward-cursor-on’ is not known to be defined.
test/test-highlighting.el:33:16: Warning: the function ‘face-at-cursor-p’ is not known to be defined.
test/test-highlighting.el:31:6: Warning: the function ‘with-hcl-temp-buffer’ is not known to be defined.
In end of data:
test/test-indentation.el:35:6: Warning: the function ‘forward-cursor-on’ is not known to be defined.
test/test-indentation.el:29:4: Warning: the function ‘with-hcl-temp-buffer’ is not known to be defined.
Its byte-compilation seems to be broken, because it prints warnings about unused values that seem to be completely spurious, the code it complains about does not even have a let binding to begin with. With that said, the testing matrix already has 24.5, so there's little point in additionally testing an older Emacs 24.
Hi-Angel
force-pushed
the
fix-warnings
branch
from
1ef6e88 to
f59ea73
Compare
|
Unlocked the convo here, but merged now anyway, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements 3 things:
.elcfiles