Merge pull request #1243 from hcoles/bug/consitent_history_order

explicitly order history file entries
hcoles · Aug 3, 2023 · 10bb6c1 · 10bb6c1
2 parents 2ebd45f + eb38915
commit 10bb6c1
Show file tree

Hide file tree

Showing 2 changed files with 37 additions and 4 deletions.
diff --git a/pitest-entry/src/main/java/org/pitest/mutationtest/tooling/MutationCoverage.java b/pitest-entry/src/main/java/org/pitest/mutationtest/tooling/MutationCoverage.java
@@ -67,6 +67,7 @@
 import java.util.ArrayList;
 import java.util.Collection;
 import java.util.Collections;
+import java.util.Comparator;
 import java.util.HashSet;
 import java.util.List;
 import java.util.Optional;
@@ -289,9 +290,14 @@ private MutationResultInterceptor resultInterceptor() {
   }
 
   private void recordClassPath(HistoryStore history, CoverageDatabase coverageData) {
-    final Set<ClassName> allClassNames = getAllClassesAndTests(coverageData);
-    final Collection<HierarchicalClassId> ids = FCollection.map(
-        this.code.getClassInfo(allClassNames), ClassInfo::getHierarchicalId);
+    Set<ClassName> allClassNames = getAllClassesAndTests(coverageData);
+
+    // sort by classname to ensure order consistent across machines
+    List<HierarchicalClassId> ids = this.code.getClassInfo(allClassNames).stream()
+            .map(ClassInfo::getHierarchicalId)
+            .sorted(Comparator.comparing(HierarchicalClassId::getName))
+            .collect(Collectors.toList());
+
     history.recordClassPath(ids, coverageData);
   }
 

diff --git a/pitest-entry/src/test/java/org/pitest/mutationtest/tooling/MutationCoverageReportTest.java b/pitest-entry/src/test/java/org/pitest/mutationtest/tooling/MutationCoverageReportTest.java
@@ -14,6 +14,7 @@
  */
 package org.pitest.mutationtest.tooling;
 
+import static java.util.Arrays.asList;
 import static org.junit.Assert.assertEquals;
 import static org.junit.Assert.fail;
 import static org.mockito.ArgumentMatchers.anyCollection;
@@ -163,7 +164,33 @@ public void shouldRecordClassPath() {
 
     createAndRunTestee();
 
-    verify(this.history).recordClassPath(Arrays.asList(fooId), this.coverageDb);
+    verify(this.history).recordClassPath(asList(fooId), this.coverageDb);
+  }
+
+  @Test
+  public void ordersHistoryEntries() {
+
+    final ClassName clazz = ClassName.fromClass(Foo.class);
+
+    final HierarchicalClassId fooId = new HierarchicalClassId(
+            new ClassIdentifier(0, clazz), "0");
+    final HierarchicalClassId barId = new HierarchicalClassId(
+            new ClassIdentifier(0, ClassName.fromString("Bar")), "0");
+    final ClassInfo foo = ClassInfoMother.make(fooId.getId());
+    final ClassInfo bar = ClassInfoMother.make(barId.getId());
+
+    when(this.mutater.findMutations(ClassName.fromClass(Foo.class))).thenReturn(aMutantIn(Foo.class));
+
+    when(this.code.getCodeUnderTestNames()).thenReturn(
+            Collections.singleton(clazz));
+    when(this.code.getClassInfo(anyCollection())).thenReturn(
+           asList(foo, bar));
+    when(this.coverageDb.getCodeLinesForClass(clazz)).thenReturn(new ClassLines(clazz, Collections.emptySet()));
+
+    createAndRunTestee();
+
+    // bar comes first alphabetically
+    verify(this.history).recordClassPath(asList(barId, fooId), this.coverageDb);
   }
 
   @Test