Merge pull request #853 from hcoles/fix-case-insensitive-feature-check

Make check for available features case insensitive
hcoles · Jan 4, 2021 · f0c054f · f0c054f
2 parents c0732d4 + d2254a5
commit f0c054f
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 2 deletions.
diff --git a/pitest-entry/src/main/java/org/pitest/mutationtest/config/SettingsFactory.java b/pitest-entry/src/main/java/org/pitest/mutationtest/config/SettingsFactory.java
@@ -112,11 +112,11 @@ public void describeFeatures(Consumer<Feature> enabled, Consumer<Feature> disabl
   public void checkRequestedFeatures() {
     FeatureParser parser = new FeatureParser();
     Set<String> available = this.plugins.findFeatures().stream()
-            .map(f -> f.provides().name())
+            .map(f -> f.provides().name().toUpperCase())
             .collect(Collectors.toSet());
 
     Optional<FeatureSetting> unknown = parser.parseFeatures(this.options.getFeatures()).stream()
-            .filter(f -> !available.contains(f.feature()))
+            .filter(f -> !available.contains(f.feature().toUpperCase()))
             .findAny();
 
     unknown.ifPresent(setting -> {

diff --git a/pitest-entry/src/test/java/org/pitest/mutationtest/config/SettingsFactoryTest.java b/pitest-entry/src/test/java/org/pitest/mutationtest/config/SettingsFactoryTest.java
@@ -137,4 +137,13 @@ public void shouldErrorWhenUnkownFeatureRequested() {
 
   }
 
+  @Test
+  public void shouldTreatFeaturesAsCaseInsensitive() {
+    this.options.setFeatures(Arrays.asList("+feNUm"));
+
+    assertThatCode( () ->this.testee.checkRequestedFeatures())
+            .doesNotThrowAnyException();
+
+  }
+
 }