[pitest-maven] report-aggregate fails while loading mutator class

[aurelien-baudet]

I run pitmp with descartes mutationEngine on my whole project to generate reports for each module.
Then I run pitest-maven report-aggregate on a reporting module (dedicated module that has dependencies to all other modules).
I get the following error:

[ERROR] Failed to execute goal org.pitest:pitest-maven:1.4.7:report-aggregate (merge-pitest-reports) on project reporting: An error has occurred in PIT Test Report report generation.: Cannot convert to mutator: false: Unable to load Mutator for class: false -> [Help 1]

The issue comes either from this code (in ReportAggregator):

private static Function<MutationResult, List<String>> resultToMutatorName() {
    return a -> {
      try {
        final String mutatorName = MutatorUtil.loadMutator(a.getDetails().getMutator()).getName();
        return Collections.singletonList(mutatorName);
      } catch (final Exception e) {
        throw new RuntimeException("Cannot convert to mutator: " + a.getDetails().getMutator(), e);
      }
    };
  }

or this code (in MutationResultDataLoader):

protected MutationResult mapToData(final Map<String, Object> map) {
    final Location location = new Location(ClassName.fromString((String) map.get(MUTATED_CLASS)), MethodName.fromString((String) map.get(MUTATED_METHOD)),
        (String) map.get(METHOD_DESCRIPTION));

    final MutationIdentifier id = new MutationIdentifier(location, Arrays.asList(new Integer((String) map.get(INDEX))), (String) map.get(MUTATOR));

    final MutationDetails md = new MutationDetails(id, (String) map.get(SOURCE_FILE), (String) map.get(DESCRIPTION),
        Integer.parseInt((String) map.get(LINE_NUMBER)), Integer.parseInt((String) map.get(BLOCK)));

    final MutationStatusTestPair status = new MutationStatusTestPair(Integer.parseInt((String) map.get(NUMBER_OF_TESTS_RUN)),
        DetectionStatus.valueOf((String) map.get(STATUS)), (String) map.get(KILLING_TEST));

    return new MutationResult(md, status);
  }

The mapToData method converts the XML data into a MutationResult. The MutationIdentifier references the mutatorUniqueId. However MutatorUtil.loadMutator expects a class name to load a MethodMutatorFactory instance from a.getDetails().getMutator() (which returns the mutatorUniqueId instead of a class name).

A fix could be to change resultToMutatorName method by:

  private static Function<MutationResult, List<String>> resultToMutatorName() {
    return a -> {
      try {
        final String mutatorName = a.getDetails().getMutator();
        return Collections.singletonList(mutatorName);
      } catch (final Exception e) {
        throw new RuntimeException("Cannot convert to mutator: " + a.getDetails().getMutator(), e);
      }
    };
  }

or to fix XML report generation to write className instead of unique identifier.