Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sourcefiles encoding option needed #637

Closed
Vampire opened this issue Aug 26, 2019 · 0 comments · Fixed by #1029
Closed

Sourcefiles encoding option needed #637

Vampire opened this issue Aug 26, 2019 · 0 comments · Fixed by #1029

Comments

@Vampire
Copy link
Contributor

Vampire commented Aug 26, 2019

Pitest needs a source file encoding option.
Currently always the system default encoding is used, which often is not correct.
It is quite common to have UTF-8 encoded source files and build on Windows.
this causes corrupted source display in the report.
For example in my copyright I have Björn, but it is displayed as Björn, which means it is saved in UTF-8, but read in ISO-8859-1.

The (or at least one) culprit is org.pitest.mutationtest.tooling.DirectorySourceLocator.FileToReader#apply as it opens a new FileReader without specifying an encoding.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant