Support different input and output encodings #1029
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szpak
reviewed
Aug 19, 2022
| private Charset inputCharset; | ||
| private Charset outputCharset; | ||
|
|
||
| public Builder inputCharSet(Charset inputCharset) { |
There was a problem hiding this comment.
@hcoles Working on the Gradle integration, I've noticed that you mix "charset" and "charSet" for fields, "setters" and getters. Maybe they all could switched to just "charset" (with deprecating the old methods)?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on work by @qxo in #799
Finally fixes #637 which was first reported in 2011 (https://code.google.com/archive/p/pitestrunner/issues/14)