Allow supression of auto add of headless=true #1054
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 14, 2022
Pitest automatically adds -Djava.awt.headless=true to the jvm args to prevent keyboard focu being stolen on macs. The change introduces a new extention point ConfigurationUpdater to allow changes to be made to the supplied config. This interface uses the feature system, so implementations can be enabled and disabled at runtime. The previously hard coded adding of headless=true is moved into a feature. It is enabled by default, but can now be dissabled by passing features="-macos_focus" Consideration was given to only adding the param when running on OS X, but this was decided against and it would make the build inconsistent.
hcoles
force-pushed
the
feature/macos_focus
branch
from
92174a9 to
cf684f0
Compare
hcoles
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New ConfigurationUpdater interface allows this to be handled as a
feature and disabled by passed features="-macos_focus"