Relax source file attribute check #1109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The purpose of the check is to alert users that they must configure the compiler to include source file debug info. Previously all classes were checked to ensure the source file was present, however it appears there may be some scenarios in which the source file is omitted when compiling kotlin. To allow analysis of the remaining classes, the check has been relaxed so that the info must be present in at least one file, rather than all files.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The purpose of the check is to alert users that they must configure the compiler to include source file debug info.
Previously all classes were checked to ensure the source file was present, however it appears there may be some scenarios in which the source file is omitted when compiling kotlin.
To allow analysis of the remaining classes, the check has been relaxed so that the info must be present in at least one file, rather than all files.