Auto add junit-platform-launcher to classpath #1212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The pitest minions require a version of the junit-platform-launcher which matches the version of junit 5 used by the SUT. Previously this was provided by the cludge of shading it into the junit5 plugin, but this causes constant headaches with version mismatched. This change pulls in a matching version of platform-launcher in the same manner that surefire does. It also allows junit dependencies to be explicitly included pitest config should this resolution give the wrong results.
hcoles
force-pushed
the
feature/auto_add_junit_platform
branch
from
b93d9de to
9835518
Compare
This was referenced May 18, 2023
|
Is this solution avoiding the need for asking for an explicitly pitest-junit plugin version as asked at |
|
@nagkumar This (largely) removes the need to match the plugin version to the version of junit in use. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pitest minions require a version of the junit-platform-launcher which matches the version of junit 5 used by the SUT. Previously this was provided by the cludge of shading it into the junit5 plugin, but this causes constant headaches with version mismatched.
This change pulls in a matching version of platform-launcher in the same manner that surefire does. It also allows junit dependencies to be explicitly included pitest config should this resolution give the wrong results.