Use unified percentage calculation logic #1221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 26, 2023
Vampire
force-pushed
the
unified-percentage-calculation
branch
from
0ee4f1e to
28b8518
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #375
Supersedes #776
With this PR hopefully all percentage calculation uses the common logic introcuded in #638.
This should avoid everywhere showing 100% if not the full total is reached.
As a positive side-effect it also fixes a potential arithmetic exception in
getTestStrength()as it was not the divisor that was checked for zero to avoid it, probably by bad copy & paste.