filter mutations to defensive unmodifiable collection returns #1310
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's common practice in some teams to wrap mutable collections with unmodifiable wrappers before returning them from a class to prevent accidental modification of state.
Although the presence of the wrapper can be easily detected by a test that attempts to modify the state of the list, some teams do not wish to specify this behaviour.
This change provides the option to filter out mutations implementing this defensive coding pattern.
The filter is disabled by default, but can be enabled with the
+funmodifiablecollection
feature string.