Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing property for jvmArgs parameter #464 #798

Merged
merged 1 commit into from
Sep 20, 2020

Conversation

yfrolov
Copy link
Contributor

@yfrolov yfrolov commented Sep 19, 2020

Hi,

I would like to suggest a fix for the issue #464 when jvmArgs property is not being picked up by pitest-maven-plugin if passed through the CLI.

For example, in the case when I can't make any changes in pom.xml I would like to be able to supply the argument (e.g. -DjvmArgs=-ea) through the CLI and expect it to be injected into the plugin.

Thank you,
Yuriy

@hcoles hcoles merged commit 82e2e34 into hcoles:master Sep 20, 2020
@hcoles
Copy link
Owner

hcoles commented Sep 20, 2020

thanks!

@yfrolov yfrolov deleted the read_jvmArgs_from_cli branch September 20, 2020 22:57
@yfrolov
Copy link
Contributor Author

yfrolov commented Sep 20, 2020

Hello @hcoles,

Do you think this pull request should be linked to the issue #464 ?

Regards,
Yuriy

hcoles pushed a commit that referenced this pull request Jun 1, 2021
hcoles added a commit that referenced this pull request Jun 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants