Guarantee order of mutation operators #921
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The order of iteration of a hashset is not guaranteed. It is unclear if this has any observable consequences, but determinism is always preferable, and aids debugging. The order that operators applied is now explicitly based on the mutator id. It is unclear if there is any benefit to the de-deplication performed by the HashSet, but this has been retained.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The order of iteration of a hashset is not guaranteed. It is unclear if
this has any observable consequences, but determinism is always
preferable, and aids debugging.
The order that operators applied is now explicitly based on the mutator
id. It is unclear if there is any benefit to the de-deplication
performed by the HashSet, but this has been retained.