Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New maven plugin parameter: additionalClasspathElements #99

Merged
merged 1 commit into from
Feb 28, 2014

Conversation

artspb
Copy link
Contributor

@artspb artspb commented Feb 21, 2014

It works the same as classPath command line option.

@@ -466,4 +474,8 @@ public void setJavaExecutable(String javaExecutable) {
this.jvm = javaExecutable;
}

public ArrayList<String> getAdditionalClasspathElements() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not just List<String>? This construction forces code that would like to use this method to explicit use ArrayList which is often considered as a code smell.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My bad. Fixed. Thank you for your note.

@hcoles
Copy link
Owner

hcoles commented Feb 27, 2014

Hi @artspb - What's the use case for this? Why would you want to include classpath elements not defined as maven dependencies?

@artspb
Copy link
Contributor Author

artspb commented Feb 28, 2014

Hi @hcoles,
In our project we have some web module that contains Spring MCV unit tests. To reuse production xml context we need to extend test classpath with webapp directory. To perform this we use additionalClasspathElements property of maven-surefire-plugin. To get the same during mutation testing we need to have the same property of pitest-maven.

hcoles added a commit that referenced this pull request Feb 28, 2014
New maven plugin parameter: additionalClasspathElements
@hcoles hcoles merged commit 0e4cb94 into hcoles:master Feb 28, 2014
@artspb artspb deleted the additionalClasspathElements branch August 9, 2014 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants