style: fix issues in RateLimiter.

RateLimiter/RateLimiter.Tests/FakeStopwatchProviderAndBlocker.cs

@@ -15,11 +15,13 @@ internal class FakeStopwatchProviderAndBlocker : IStopwatchProvider<long>, IAsyn
     {
         private long instant = 0;
 
+        public bool IsHighResolution => throw new NotImplementedException();
+
         internal IList<long> Events { get; } = new List<long>();
 
         public long GetTimestamp()
         {
-            return instant;
+            return this.instant;
         }
 
         public TimeSpan ParseDuration(long from, long to)
@@ -34,13 +36,11 @@ public long GetNextTimestamp(long from, TimeSpan interval)
 
         public Task WaitAsync(TimeSpan timeout, CancellationToken cancellationToken)
         {
-            instant += timeout.Ticks;
-            Events.Add(timeout.Ticks);
+            this.instant += timeout.Ticks;
+            this.Events.Add(timeout.Ticks);
             return Task.FromResult<object>(null);
         }
 
-        public bool IsHighResolution => throw new NotImplementedException();
-
         public IStopwatch Create()
         {
             throw new NotImplementedException();
@@ -52,4 +52,3 @@ public IStopwatch StartNew()
         }
     }
 }
-

RateLimiter/RateLimiter.Tests/RateLimiterTest.cs

@@ -11,72 +11,71 @@ namespace RateLimiter.Tests
 {
     public class RateLimiterTest
     {
-        private readonly FakeStopwatchProviderAndBlocker stopwatchProviderAndBlocker =
-            new FakeStopwatchProviderAndBlocker();
-
-        internal IRateLimiter Create(double permitsPerSecond)
-        {
-            return Create(permitsPerSecond, 1.0);
-        }
-
-        internal IRateLimiter Create(double permitsPerSecond, double maxBurstSeconds)
-        {
-            return new SmoothBurstyRateLimiter(stopwatchProviderAndBlocker, maxBurstSeconds, stopwatchProviderAndBlocker)
-            {
-                PermitsPerSecond = permitsPerSecond
-            };
-        }
-
-        internal IRateLimiter Create(double permitsPerSecond, TimeSpan warmupPeriod)
-        {
-            return new SmoothWarmingUpRateLimiter(stopwatchProviderAndBlocker, warmupPeriod, 3, stopwatchProviderAndBlocker)
-            {
-                PermitsPerSecond = permitsPerSecond
-            };
-        }
+        private readonly FakeStopwatchProviderAndBlocker stopwatchProviderAndBlocker = new ();
 
         [Fact]
         public void TestSimple()
         {
-            var limiter = Create(5, 1);
+            var limiter = this.Create(5, 1);
             limiter.Acquire(); // R0.00, since it's the first request
             limiter.Acquire(); // R0.20
             limiter.Acquire(); // R0.20
-            Assert.Equal(new[]
+            Assert.Equal(
+                new[]
             {
-                0L, TimeSpan.FromSeconds(0.2).Ticks, TimeSpan.FromSeconds(0.2).Ticks
-            }, stopwatchProviderAndBlocker.Events);
+                0L, TimeSpan.FromSeconds(0.2).Ticks, TimeSpan.FromSeconds(0.2).Ticks,
+            }, this.stopwatchProviderAndBlocker.Events);
         }
 
         [Fact]
         public void TestImmediateTryAcquire()
         {
-            var limiter = Create(1);
+            var limiter = this.Create(1);
             Assert.True(limiter.TryAcquire().Succeed, "Unable to acquire initial permit");
             Assert.False(limiter.TryAcquire().Succeed, "Capable of acquiring secondary permit");
         }
 
         [Fact]
         public void TestDoubleMinValueCanAcquireExactlyOnce()
         {
-            var r = Create(double.Epsilon);
+            var r = this.Create(double.Epsilon);
             Assert.True(r.TryAcquire().Succeed, "Unable to acquire initial permit");
             Assert.False(r.TryAcquire().Succeed, "Capable of acquiring an additional permit");
-            stopwatchProviderAndBlocker.WaitAsync(TimeSpan.MaxValue.Subtract(TimeSpan.FromTicks(1)), CancellationToken.None).GetAwaiter().GetResult();
+            this.stopwatchProviderAndBlocker.WaitAsync(TimeSpan.MaxValue.Subtract(TimeSpan.FromTicks(1)), CancellationToken.None).GetAwaiter().GetResult();
             Assert.False(r.TryAcquire().Succeed, "Capable of acquiring an additional permit after sleeping");
         }
 
         [Fact]
         public void TestSimpleRateUpdate()
         {
-            var limiter = Create(5.0, TimeSpan.FromSeconds(5));
+            var limiter = this.Create(5.0, TimeSpan.FromSeconds(5));
             Assert.Equal(5.0, limiter.PermitsPerSecond);
             limiter.PermitsPerSecond = 10.0;
             Assert.Equal(10.0, limiter.PermitsPerSecond);
 
             Assert.Throws<ArgumentOutOfRangeException>(() => limiter.PermitsPerSecond = 0);
             Assert.Throws<ArgumentOutOfRangeException>(() => limiter.PermitsPerSecond = -10);
         }
+
+        internal IRateLimiter Create(double permitsPerSecond)
+        {
+            return this.Create(permitsPerSecond, 1.0);
+        }
+
+        internal IRateLimiter Create(double permitsPerSecond, double maxBurstSeconds)
+        {
+            return new SmoothBurstyRateLimiter(this.stopwatchProviderAndBlocker, maxBurstSeconds, this.stopwatchProviderAndBlocker)
+            {
+                PermitsPerSecond = permitsPerSecond,
+            };
+        }
+
+        internal IRateLimiter Create(double permitsPerSecond, TimeSpan warmupPeriod)
+        {
+            return new SmoothWarmingUpRateLimiter(this.stopwatchProviderAndBlocker, warmupPeriod, 3, this.stopwatchProviderAndBlocker)
+            {
+                PermitsPerSecond = permitsPerSecond,
+            };
+        }
     }
 }
-

RateLimiter/RateLimiter/AssemblyInfo.cs

@@ -6,4 +6,3 @@
 using System.Runtime.CompilerServices;
 
 [assembly: InternalsVisibleTo("RateLimiter.Tests")]
-

RateLimiter/RateLimiter/IAsyncBlocker.cs

@@ -24,4 +24,3 @@ public Task WaitAsync(TimeSpan timeout, CancellationToken cancellationToken)
         }
     }
 }
-

RateLimiter/RateLimiter/IRateLimiter.cs

@@ -70,4 +70,3 @@ public interface IRateLimiter
 #endif
     }
 }
-

RateLimiter/RateLimiter/RateLimiter.cs

@@ -17,7 +17,7 @@ public static IRateLimiter CreateBursty(
         {
             return new SmoothBurstyRateLimiter(stopwatchProvider, maxBurstSeconds)
             {
-                PermitsPerSecond = permitsPerSecond
+                PermitsPerSecond = permitsPerSecond,
             };
         }
 
@@ -29,7 +29,7 @@ public static IRateLimiter CreateWarmingUp(
         {
             return new SmoothWarmingUpRateLimiter(stopwatchProvider, warmupPeriod, coldFactor)
             {
-                PermitsPerSecond = permitsPerSecond
+                PermitsPerSecond = permitsPerSecond,
             };
         }
 
@@ -49,4 +49,3 @@ public static IRateLimiter Create(
         }
     }
 }
-

RateLimiter/RateLimiter/RateLimiter.csproj

@@ -13,7 +13,7 @@
   </PropertyGroup>
 
   <ItemGroup>
-    <ProjectReference Include="..\..\Clocks.Net\Clocks.Abstraction\Clocks.Abstraction.csproj" />
+    <ProjectReference Include="$(EnlistmentRoot)\Clocks.Net\Clocks.Abstraction\Clocks.Abstraction.csproj" />
   </ItemGroup>
 
 </Project>