Use fewer threads when running openroad. #366
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't overwhelm remote executors (which may be running multiple actions) with too many threads. Just use one unless the job is required to be run locally, in which case we expect an action will often have the entire system to itself.
|
/gcbrun |
mikesinouye
approved these changes
Nov 8, 2024
QuantamHD
reviewed
Nov 13, 2024
| # locally, in which case we expect an action will often have the entire | ||
| # system to itself. | ||
| num_threads = "1" | ||
| if "no-remote-exec" in execution_requirements: |
There was a problem hiding this comment.
Will this trigger if you run with --strategy=OpenROAD=local?
There was a problem hiding this comment.
It looks like setting the strategy still keeps num_threads=1 :/
Might be better to have num_threads be a parameter to override. WDYT?
There was a problem hiding this comment.
Could we check the opposite? i.e. is this running remotely?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't overwhelm remote executors (which may be running multiple actions) with too many threads. Just use one unless the job is required to be run locally, in which case we expect an action will often have the entire system to itself.