verilog: adds support for include headers #367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Include headers should not appear in the verilator command line, but should be available in the compilation sandbox. It seems that verilator rules did not allow `hdrs` files into the sandbox, so this change fixes the issue. Furthermore, very often core authors use the include directive to read an include file from the directory where the include file is located: ``` `include "file.h" ``` This will not work in bazel, because the expected include path is: ``` `include "directory/where/file/resides/file.h" ``` This rule adds the `includes` parameter to `verilog_library` to allow the user to specify a set of include directories, therefore allowing verilation of included cores. The `verilator_cc_library` rules is fixed to suport this. It is also fixed to use the `hdrs` files as inputs to the verilation rule.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Include headers should not appear in the verilator command line, but should be available in the compilation sandbox.
It seems that verilator rules did not allow
hdrsfiles into the sandbox, so this change fixes the issue.Furthermore, very often core authors use the include directive to read an include file from the directory where the include file is located:
This will not work in bazel, because the expected include path is:
This rule adds the
includesparameter toverilog_libraryto allow the user to specify a set of include directories, therefore allowing verilation of included cores.The
verilator_cc_libraryrules is fixed to suport this. It is also fixed to use thehdrsfiles as inputs to the verilation rule.